Eliminate usage of InterfacePtr::WaitForIncomingResponse.

services/ui/public/cpp/lib/command_buffer_client_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/public/cpp/lib/command_buffer_client_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
@@ skipping 22 matching lines @@
   if (!handle->is_valid())
     return false;
 
   *mapping = (*handle)->Map(size);
   if (!*mapping)
     return false;
 
   return true;
 }
 
-void MakeProgressCallback(gpu::CommandBuffer::State* output,
-                          const gpu::CommandBuffer::State& input) {
-  *output = input;
-}
-
-void InitializeCallback(ui::mojom::CommandBufferInitializeResultPtr* output,
-                        ui::mojom::CommandBufferInitializeResultPtr input) {
-  *output = std::move(input);
-}
-
 }  // namespace
 
 CommandBufferClientImpl::CommandBufferClientImpl(
     const std::vector<int32_t>& attribs,
     ui::mojom::CommandBufferPtr command_buffer_ptr)
     : gpu_control_client_(nullptr),
       destroyed_(false),
       attribs_(attribs),
       client_binding_(this),
       command_buffer_(std::move(command_buffer_ptr)),
@@ skipping 17 matching lines @@
       CreateAndMapSharedBuffer(kSharedStateSize, &shared_state_, &handle);
   if (!result)
     return false;
 
   shared_state()->Initialize();
 
   ui::mojom::CommandBufferClientPtr client_ptr;
   client_binding_.Bind(GetProxy(&client_ptr));
 
   ui::mojom::CommandBufferInitializeResultPtr initialize_result;
-  command_buffer_->Initialize(
+  bool handled = command_buffer_->Initialize(

[Peng, 2016/07/06 17:31:02]

result = command_buffer_->Initialize(?

[leonhsl(Using Gerrit), 2016/07/07 07:43:12]

Done.

       std::move(client_ptr), std::move(handle),
-      mojo::Array<int32_t>::From(attribs_),
-      base::Bind(&InitializeCallback, &initialize_result));
+      mojo::Array<int32_t>::From(attribs_), &initialize_result);
 
-  base::ThreadRestrictions::ScopedAllowWait wait;
-  if (!command_buffer_.WaitForIncomingResponse()) {
+  if (!handled) {
     VLOG(1) << "Channel encountered error while creating command buffer.";
     return false;
   }
 
   if (!initialize_result) {
     VLOG(1) << "Command buffer cannot be initialized successfully.";
     return false;
   }
 
   DCHECK_EQ(gpu::CommandBufferNamespace::MOJO,
@@ skipping 183 matching lines @@
 void CommandBufferClientImpl::UpdateVSyncParameters(int64_t timebase,
                                                     int64_t interval) {}
 
 void CommandBufferClientImpl::TryUpdateState() {
   if (last_state_.error == gpu::error::kNoError)
     shared_state()->Read(&last_state_);
 }
 
 void CommandBufferClientImpl::MakeProgressAndUpdateState() {
   gpu::CommandBuffer::State state;
-  command_buffer_->MakeProgress(last_state_.get_offset,
-                                base::Bind(&MakeProgressCallback, &state));
+  bool handled = command_buffer_->MakeProgress(last_state_.get_offset, &state);

[Peng, 2016/07/06 17:31:02]

bool result = command_buffer_->MakeProgress(...?

[leonhsl(Using Gerrit), 2016/07/07 07:43:12]

Done.

 
-  base::ThreadRestrictions::ScopedAllowWait wait;
-  if (!command_buffer_.WaitForIncomingResponse()) {
+  if (!handled) {
     VLOG(1) << "Channel encountered error while waiting for command buffer.";
     // TODO(piman): is it ok for this to re-enter?
     Destroyed(gpu::error::kUnknown, gpu::error::kLostContext);
     return;
   }
 
   if (state.generation - last_state_.generation < 0x80000000U)
     last_state_ = state;
 }
 
@@ skipping 46 matching lines @@
 
   // It is also safe to wait on the same context.
   if (sync_token->namespace_id() == gpu::CommandBufferNamespace::MOJO &&
       sync_token->command_buffer_id() == GetCommandBufferID())
     return true;
 
   return false;
 }
 
 }  // namespace ui