Eliminate usage of InterfacePtr::WaitForIncomingResponse.

components/leveldb/leveldb_service_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/macros.h"
+#include "base/run_loop.h"
 #include "components/filesystem/public/interfaces/directory.mojom.h"
 #include "components/filesystem/public/interfaces/file_system.mojom.h"
 #include "components/filesystem/public/interfaces/types.mojom.h"
 #include "components/leveldb/public/interfaces/leveldb.mojom.h"
 #include "mojo/common/common_type_converters.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
 #include "services/shell/public/cpp/shell_connection.h"
 #include "services/shell/public/cpp/shell_test.h"
 
 using filesystem::mojom::FileError;
 
 namespace leveldb {
 namespace {
 
 template <typename... Args> void IgnoreAllArgs(Args&&...) {}
 
 template <typename... Args>
-void DoCaptures(Args*... out_args, Args... in_args) {
+void DoCaptures(Args*... out_args,
+                const base::Closure& quit_closure,
+                Args... in_args) {
   IgnoreAllArgs((*out_args = std::move(in_args))...);
+  if (!quit_closure.is_null())

[Elliot Glaysher, 2016/07/06 16:44:30]

Is this ever actually null?

[leonhsl(Using Gerrit), 2016/07/07 07:43:12]

Removed the null check. I was assuming that some callers of Capture() maybe do
not need |quit_closure|, but it comes out that actually such case does not
exist.

+    quit_closure.Run();
 }
 
 template <typename T1>
-base::Callback<void(T1)> Capture(T1* t1) {
-  return base::Bind(&DoCaptures<T1>, t1);
+base::Callback<void(T1)> Capture(
+    T1* t1,
+    const base::Closure& quit_closure = base::Closure()) {
+  return base::Bind(&DoCaptures<T1>, t1, quit_closure);
 }
 
 template <typename T1, typename T2>
-base::Callback<void(T1, T2)> Capture(T1* t1, T2* t2) {
-  return base::Bind(&DoCaptures<T1, T2>, t1, t2);
+base::Callback<void(T1, T2)>
+Capture(T1* t1, T2* t2, const base::Closure& quit_closure = base::Closure()) {

[Elliot Glaysher, 2016/07/06 16:44:30]

Don't use default parameters.

[leonhsl(Using Gerrit), 2016/07/07 07:43:12]

Done.

+  return base::Bind(&DoCaptures<T1, T2>, t1, t2, quit_closure);
+}
+
+void DatabaseSyncPut(mojom::LevelDBDatabasePtr& database,

[yzshen1, 2016/07/06 16:50:26]

nit: |database| could be "mojom::LevelDBDatabase*" and the callsite will be
DatabaseSyncPut(database_ptr.get(), ...)

[leonhsl(Using Gerrit), 2016/07/07 07:43:12]

Done.

+                     mojo::Array<uint8_t> key,
+                     mojo::Array<uint8_t> value,
+                     mojom::DatabaseError* out_error) {
+  base::RunLoop run_loop;
+  database->Put(std::move(key), std::move(value),
+                Capture(out_error, run_loop.QuitClosure()));
+  run_loop.Run();
+}
+
+void DatabaseSyncGet(mojom::LevelDBDatabasePtr& database,
+                     mojo::Array<uint8_t> key,
+                     mojom::DatabaseError* out_error,
+                     mojo::Array<uint8_t>* out_value) {
+  base::RunLoop run_loop;
+  database->Get(std::move(key),
+                Capture(out_error, out_value, run_loop.QuitClosure()));
+  run_loop.Run();
+}
+
+void DatabaseSyncGetPrefixed(mojom::LevelDBDatabasePtr& database,
+                             mojo::Array<uint8_t> key_prefix,
+                             mojom::DatabaseError* out_error,
+                             mojo::Array<mojom::KeyValuePtr>* out_key_values) {
+  base::RunLoop run_loop;
+  database->GetPrefixed(
+      std::move(key_prefix),
+      Capture(out_error, out_key_values, run_loop.QuitClosure()));
+  run_loop.Run();
+}
+
+void DatabaseSyncDeletePrefixed(mojom::LevelDBDatabasePtr& database,
+                                mojo::Array<uint8_t> key_prefix,
+                                mojom::DatabaseError* out_error) {
+  base::RunLoop run_loop;
+  database->DeletePrefixed(std::move(key_prefix),
+                           Capture(out_error, run_loop.QuitClosure()));
+  run_loop.Run();
+}
+
+void LevelDBSyncOpenInMemory(mojom::LevelDBServicePtr& leveldb,
+                             mojom::LevelDBDatabaseRequest database,
+                             mojom::DatabaseError* out_error) {
+  base::RunLoop run_loop;
+  leveldb->OpenInMemory(std::move(database),
+                        Capture(out_error, run_loop.QuitClosure()));
+  run_loop.Run();
 }
 
 class LevelDBServiceTest : public shell::test::ShellTest {
  public:
   LevelDBServiceTest() : ShellTest("exe:leveldb_service_unittests") {}
   ~LevelDBServiceTest() override {}
 
  protected:
   // Overridden from mojo::test::ApplicationTestBase:
   void SetUp() override {
     ShellTest::SetUp();
     connector()->ConnectToInterface("mojo:filesystem", &files_);
     connector()->ConnectToInterface("mojo:leveldb", &leveldb_);
   }
 
   void TearDown() override {
     leveldb_.reset();
     files_.reset();
     ShellTest::TearDown();
   }
 
   // Note: This has an out parameter rather than returning the |DirectoryPtr|,
   // since |ASSERT_...()| doesn't work with return values.
   void GetTempDirectory(filesystem::mojom::DirectoryPtr* directory) {
     FileError error = FileError::FAILED;
-    files()->OpenTempDirectory(GetProxy(directory), Capture(&error));
-    ASSERT_TRUE(files().WaitForIncomingResponse());
+    bool handled = files()->OpenTempDirectory(GetProxy(directory), &error);
+    ASSERT_TRUE(handled);
     ASSERT_EQ(FileError::OK, error);
   }
 
   filesystem::mojom::FileSystemPtr& files() { return files_; }
   mojom::LevelDBServicePtr& leveldb() { return leveldb_; }
 
  private:
   filesystem::mojom::FileSystemPtr files_;
   mojom::LevelDBServicePtr leveldb_;
 
   DISALLOW_COPY_AND_ASSIGN(LevelDBServiceTest);
 };
 
 TEST_F(LevelDBServiceTest, Basic) {
   mojom::DatabaseError error;
   mojom::LevelDBDatabasePtr database;
-  leveldb()->OpenInMemory(GetProxy(&database), Capture(&error));
-  ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+  LevelDBSyncOpenInMemory(leveldb(), GetProxy(&database), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Write a key to the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->Put(mojo::Array<uint8_t>::From(std::string("key")),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Read the key back from the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   mojo::Array<uint8_t> value;
-  database->Get(mojo::Array<uint8_t>::From(std::string("key")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ("value", value.To<std::string>());
 
   // Delete the key from the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
+  base::RunLoop run_loop;
   database->Delete(mojo::Array<uint8_t>::From(std::string("key")),
-                   Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+                   Capture(&error, run_loop.QuitClosure()));
+  run_loop.Run();
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Read the key back from the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   value.SetToEmpty();
-  database->Get(mojo::Array<uint8_t>::From(std::string("key")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::NOT_FOUND, error);
   EXPECT_EQ("", value.To<std::string>());
 }
 
 TEST_F(LevelDBServiceTest, WriteBatch) {
   mojom::DatabaseError error;
   mojom::LevelDBDatabasePtr database;
-  leveldb()->OpenInMemory(GetProxy(&database), Capture(&error));
-  ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+  LevelDBSyncOpenInMemory(leveldb(), GetProxy(&database), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Write a key to the database.
-  database->Put(mojo::Array<uint8_t>::From(std::string("key")),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Create a batched operation which both deletes "key" and adds another write.
   mojo::Array<mojom::BatchedOperationPtr> operations;
   mojom::BatchedOperationPtr item = mojom::BatchedOperation::New();
   item->type = mojom::BatchOperationType::DELETE_KEY;
   item->key = mojo::Array<uint8_t>::From(std::string("key"));
   operations.push_back(std::move(item));
 
   item = mojom::BatchedOperation::New();
   item->type = mojom::BatchOperationType::PUT_KEY;
   item->key = mojo::Array<uint8_t>::From(std::string("other"));
   item->value = mojo::Array<uint8_t>::From(std::string("more"));
   operations.push_back(std::move(item));
 
-  database->Write(std::move(operations), Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  base::RunLoop run_loop;
+  database->Write(std::move(operations),
+                  Capture(&error, run_loop.QuitClosure()));
+  run_loop.Run();
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Reading "key" should be invalid now.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   mojo::Array<uint8_t> value;
-  database->Get(mojo::Array<uint8_t>::From(std::string("key")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::NOT_FOUND, error);
   EXPECT_EQ("", value.To<std::string>());
 
   // Reading "other" should return "more"
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->Get(mojo::Array<uint8_t>::From(std::string("other")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database, mojo::Array<uint8_t>::From(std::string("other")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ("more", value.To<std::string>());
 
   // Write a some prefixed keys to the database.
-  database->Put(mojo::Array<uint8_t>::From(std::string("prefix-key1")),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database,
+                  mojo::Array<uint8_t>::From(std::string("prefix-key1")),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
-  database->Put(mojo::Array<uint8_t>::From(std::string("prefix-key2")),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database,
+                  mojo::Array<uint8_t>::From(std::string("prefix-key2")),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Create a batched operation to delete them.
   operations.SetToEmpty();
   item = mojom::BatchedOperation::New();
   item->type = mojom::BatchOperationType::DELETE_PREFIXED_KEY;
   item->key = mojo::Array<uint8_t>::From(std::string("prefix"));
   operations.push_back(std::move(item));
-  database->Write(std::move(operations), Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  base::RunLoop run_loop2;
+  database->Write(std::move(operations),
+                  Capture(&error, run_loop2.QuitClosure()));
+  run_loop2.Run();
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Reading all "prefix" keys should be invalid now.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   value = nullptr;
-  database->Get(mojo::Array<uint8_t>::From(std::string("prefix-key1")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database,
+                  mojo::Array<uint8_t>::From(std::string("prefix-key1")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::NOT_FOUND, error);
   EXPECT_EQ("", value.To<std::string>());
   // Reading "key" should be invalid now.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   value = nullptr;
-  database->Get(mojo::Array<uint8_t>::From(std::string("prefix-key2")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database,
+                  mojo::Array<uint8_t>::From(std::string("prefix-key2")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::NOT_FOUND, error);
   EXPECT_EQ("", value.To<std::string>());
 }
 
 TEST_F(LevelDBServiceTest, Reconnect) {
   mojom::DatabaseError error;
 
   filesystem::mojom::DirectoryPtr temp_directory;
   GetTempDirectory(&temp_directory);
 
   {
     filesystem::mojom::DirectoryPtr directory;
     temp_directory->Clone(GetProxy(&directory));
 
     mojom::LevelDBDatabasePtr database;
     leveldb::mojom::OpenOptionsPtr options = leveldb::mojom::OpenOptions::New();
     options->error_if_exists = true;
     options->create_if_missing = true;
-    leveldb()->OpenWithOptions(std::move(options),
-                               std::move(directory), "test",
+    base::RunLoop run_loop;
+    leveldb()->OpenWithOptions(std::move(options), std::move(directory), "test",
                                GetProxy(&database),
-                               Capture(&error));
-    ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+                               Capture(&error, run_loop.QuitClosure()));
+    run_loop.Run();
     EXPECT_EQ(mojom::DatabaseError::OK, error);
 
     // Write a key to the database.
     error = mojom::DatabaseError::INVALID_ARGUMENT;
-    database->Put(mojo::Array<uint8_t>::From(std::string("key")),
-                  mojo::Array<uint8_t>::From(std::string("value")),
-                  Capture(&error));
-    ASSERT_TRUE(database.WaitForIncomingResponse());
+    DatabaseSyncPut(database, mojo::Array<uint8_t>::From(std::string("key")),
+                    mojo::Array<uint8_t>::From(std::string("value")), &error);
     EXPECT_EQ(mojom::DatabaseError::OK, error);
 
     // The database should go out of scope here.
   }
 
   {
     filesystem::mojom::DirectoryPtr directory;
     temp_directory->Clone(GetProxy(&directory));
 
     // Reconnect to the database.
     mojom::LevelDBDatabasePtr database;
+    base::RunLoop run_loop;
     leveldb()->Open(std::move(directory), "test", GetProxy(&database),
-                    Capture(&error));
-    ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+                    Capture(&error, run_loop.QuitClosure()));
+    run_loop.Run();
     EXPECT_EQ(mojom::DatabaseError::OK, error);
 
     // We should still be able to read the key back from the database.
     error = mojom::DatabaseError::INVALID_ARGUMENT;
     mojo::Array<uint8_t> value;
-    database->Get(mojo::Array<uint8_t>::From(std::string("key")),
-                  Capture(&error, &value));
-    ASSERT_TRUE(database.WaitForIncomingResponse());
+    DatabaseSyncGet(database, mojo::Array<uint8_t>::From(std::string("key")),
+                    &error, &value);
     EXPECT_EQ(mojom::DatabaseError::OK, error);
     EXPECT_EQ("value", value.To<std::string>());
   }
 }
 
 TEST_F(LevelDBServiceTest, GetSnapshotSimple) {
   mojom::DatabaseError error;
   mojom::LevelDBDatabasePtr database;
-  leveldb()->OpenInMemory(GetProxy(&database), Capture(&error));
-  ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+  LevelDBSyncOpenInMemory(leveldb(), GetProxy(&database), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   uint64_t snapshot_id = 0;
-  database->GetSnapshot(Capture(&snapshot_id));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  base::RunLoop run_loop;
+  database->GetSnapshot(Capture(&snapshot_id, run_loop.QuitClosure()));
+  run_loop.Run();
   EXPECT_NE(static_cast<uint64_t>(0), snapshot_id);
 }
 
 TEST_F(LevelDBServiceTest, GetFromSnapshots) {
   mojom::DatabaseError error;
   mojom::LevelDBDatabasePtr database;
-  leveldb()->OpenInMemory(GetProxy(&database), Capture(&error));
-  ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+  LevelDBSyncOpenInMemory(leveldb(), GetProxy(&database), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Write a key to the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->Put(mojo::Array<uint8_t>::From(std::string("key")),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Take a snapshot where key=value.
   uint64_t key_value_snapshot = 0;
-  database->GetSnapshot(Capture(&key_value_snapshot));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  base::RunLoop run_loop;
+  database->GetSnapshot(Capture(&key_value_snapshot, run_loop.QuitClosure()));
+  run_loop.Run();
 
   // Change key to "yek".
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->Put(mojo::Array<uint8_t>::From(std::string("key")),
-                mojo::Array<uint8_t>::From(std::string("yek")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  mojo::Array<uint8_t>::From(std::string("yek")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // (Ensure this change is live on the database.)
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   mojo::Array<uint8_t> value;
-  database->Get(mojo::Array<uint8_t>::From(std::string("key")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ("yek", value.To<std::string>());
 
   // But if we were to read from the snapshot, we'd still get value.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   value.SetToEmpty();
-  database->GetFromSnapshot(
-      key_value_snapshot,
-      mojo::Array<uint8_t>::From(std::string("key")),
-      Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  base::RunLoop run_loop2;
+  database->GetFromSnapshot(key_value_snapshot,
+                            mojo::Array<uint8_t>::From(std::string("key")),
+                            Capture(&error, &value, run_loop2.QuitClosure()));
+  run_loop2.Run();
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ("value", value.To<std::string>());
 }
 
 TEST_F(LevelDBServiceTest, InvalidArgumentOnInvalidSnapshot) {
   mojom::LevelDBDatabasePtr database;
   mojom::DatabaseError error = mojom::DatabaseError::INVALID_ARGUMENT;
-  leveldb()->OpenInMemory(GetProxy(&database), Capture(&error));
-  ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+  LevelDBSyncOpenInMemory(leveldb(), GetProxy(&database), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   uint64_t invalid_snapshot = 8;
 
   error = mojom::DatabaseError::OK;
   mojo::Array<uint8_t> value;
-  database->GetFromSnapshot(
-      invalid_snapshot,
-      mojo::Array<uint8_t>::From(std::string("key")),
-      Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  base::RunLoop run_loop;
+  database->GetFromSnapshot(invalid_snapshot,
+                            mojo::Array<uint8_t>::From(std::string("key")),
+                            Capture(&error, &value, run_loop.QuitClosure()));
+  run_loop.Run();
   EXPECT_EQ(mojom::DatabaseError::INVALID_ARGUMENT, error);
 }
 
 TEST_F(LevelDBServiceTest, MemoryDBReadWrite) {
   mojom::LevelDBDatabasePtr database;
   mojom::DatabaseError error = mojom::DatabaseError::INVALID_ARGUMENT;
-  leveldb()->OpenInMemory(GetProxy(&database), Capture(&error));
-  ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+  LevelDBSyncOpenInMemory(leveldb(), GetProxy(&database), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Write a key to the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->Put(mojo::Array<uint8_t>::From(std::string("key")),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Read the key back from the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   mojo::Array<uint8_t> value;
-  database->Get(mojo::Array<uint8_t>::From(std::string("key")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ("value", value.To<std::string>());
 
   // Delete the key from the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
+  base::RunLoop run_loop;
   database->Delete(mojo::Array<uint8_t>::From(std::string("key")),
-                   Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+                   Capture(&error, run_loop.QuitClosure()));
+  run_loop.Run();
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   // Read the key back from the database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   value.SetToEmpty();
-  database->Get(mojo::Array<uint8_t>::From(std::string("key")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database, mojo::Array<uint8_t>::From(std::string("key")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::NOT_FOUND, error);
   EXPECT_EQ("", value.To<std::string>());
 }
 
 TEST_F(LevelDBServiceTest, Prefixed) {
   // Open an in memory database for speed.
   mojom::DatabaseError error = mojom::DatabaseError::INVALID_ARGUMENT;
   mojom::LevelDBDatabasePtr database;
-  leveldb()->OpenInMemory(GetProxy(&database), Capture(&error));
-  ASSERT_TRUE(leveldb().WaitForIncomingResponse());
+  LevelDBSyncOpenInMemory(leveldb(), GetProxy(&database), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
 
   const std::string prefix("prefix");
   mojo::Array<mojom::KeyValuePtr> key_values;
 
   // Completely empty database.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->GetPrefixed(mojo::Array<uint8_t>::From(prefix),
-                        Capture(&error, &key_values));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGetPrefixed(database, mojo::Array<uint8_t>::From(prefix), &error,
+                          &key_values);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_TRUE(key_values.empty());
 
   // No values with our prefix, but values before and after.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->Put(mojo::Array<uint8_t>::From(std::string("a-before-prefix")),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database,
+                  mojo::Array<uint8_t>::From(std::string("a-before-prefix")),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->Put(mojo::Array<uint8_t>::From(std::string("z-after-prefix")),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database,
+                  mojo::Array<uint8_t>::From(std::string("z-after-prefix")),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   key_values.SetToEmpty();
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->GetPrefixed(mojo::Array<uint8_t>::From(prefix),
-                        Capture(&error, &key_values));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGetPrefixed(database, mojo::Array<uint8_t>::From(prefix), &error,
+                          &key_values);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_TRUE(key_values.empty());
 
   // One value with the exact prefix.
-  database->Put(mojo::Array<uint8_t>::From(prefix),
-                mojo::Array<uint8_t>::From(std::string("value")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database, mojo::Array<uint8_t>::From(prefix),
+                  mojo::Array<uint8_t>::From(std::string("value")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   key_values.SetToEmpty();
-  database->GetPrefixed(mojo::Array<uint8_t>::From(prefix),
-                        Capture(&error, &key_values));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGetPrefixed(database, mojo::Array<uint8_t>::From(prefix), &error,
+                          &key_values);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ(1u, key_values.size());
   EXPECT_EQ("prefix", key_values[0]->key.To<std::string>());
   EXPECT_EQ("value", key_values[0]->value.To<std::string>());
 
   // Multiple values with starting with the prefix.
-  database->Put(mojo::Array<uint8_t>::From(prefix + "2"),
-                mojo::Array<uint8_t>::From(std::string("value2")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database, mojo::Array<uint8_t>::From(prefix + "2"),
+                  mojo::Array<uint8_t>::From(std::string("value2")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   key_values.SetToEmpty();
-  database->GetPrefixed(mojo::Array<uint8_t>::From(prefix),
-                        Capture(&error, &key_values));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGetPrefixed(database, mojo::Array<uint8_t>::From(prefix), &error,
+                          &key_values);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ(2u, key_values.size());
   EXPECT_EQ("prefix", key_values[0]->key.To<std::string>());
   EXPECT_EQ("value", key_values[0]->value.To<std::string>());
   EXPECT_EQ("prefix2", key_values[1]->key.To<std::string>());
   EXPECT_EQ("value2", key_values[1]->value.To<std::string>());
 
   // Delete the prefixed values.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->DeletePrefixed(mojo::Array<uint8_t>::From(prefix),
-                          Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncDeletePrefixed(database, mojo::Array<uint8_t>::From(prefix),
+                             &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   key_values.SetToEmpty();
-  database->GetPrefixed(mojo::Array<uint8_t>::From(prefix),
-                        Capture(&error, &key_values));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGetPrefixed(database, mojo::Array<uint8_t>::From(prefix), &error,
+                          &key_values);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_TRUE(key_values.empty());
 
   // Make sure the others are not deleted.
   mojo::Array<uint8_t> value;
-  database->Get(mojo::Array<uint8_t>::From(std::string("a-before-prefix")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database,
+                  mojo::Array<uint8_t>::From(std::string("a-before-prefix")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ("value", value.To<std::string>());
   value.SetToEmpty();
-  database->Get(mojo::Array<uint8_t>::From(std::string("z-after-prefix")),
-                Capture(&error, &value));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGet(database,
+                  mojo::Array<uint8_t>::From(std::string("z-after-prefix")),
+                  &error, &value);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ("value", value.To<std::string>());
 
   // A key having our prefix, but no key matching it exactly.
   // Even thought there is no exact matching key, GetPrefixed
   // and DeletePrefixed still operate on the values.
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->Put(mojo::Array<uint8_t>::From(prefix + "2"),
-                mojo::Array<uint8_t>::From(std::string("value2")),
-                Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncPut(database, mojo::Array<uint8_t>::From(prefix + "2"),
+                  mojo::Array<uint8_t>::From(std::string("value2")), &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   key_values.SetToEmpty();
-  database->GetPrefixed(mojo::Array<uint8_t>::From(prefix),
-                        Capture(&error, &key_values));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGetPrefixed(database, mojo::Array<uint8_t>::From(prefix), &error,
+                          &key_values);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_EQ(1u, key_values.size());
   EXPECT_EQ("prefix2", key_values[0]->key.To<std::string>());
   EXPECT_EQ("value2", key_values[0]->value.To<std::string>());
   error = mojom::DatabaseError::INVALID_ARGUMENT;
-  database->DeletePrefixed(mojo::Array<uint8_t>::From(prefix),
-                          Capture(&error));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncDeletePrefixed(database, mojo::Array<uint8_t>::From(prefix),
+                             &error);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   error = mojom::DatabaseError::INVALID_ARGUMENT;
   key_values.SetToEmpty();
-  database->GetPrefixed(mojo::Array<uint8_t>::From(prefix),
-                        Capture(&error, &key_values));
-  ASSERT_TRUE(database.WaitForIncomingResponse());
+  DatabaseSyncGetPrefixed(database, mojo::Array<uint8_t>::From(prefix), &error,
+                          &key_values);
   EXPECT_EQ(mojom::DatabaseError::OK, error);
   EXPECT_TRUE(key_values.empty());
 }
 
 }  // namespace
 }  // namespace leveldb