Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2096283003: X87: [builtins] Introduce a proper BUILTIN frame type. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce a proper BUILTIN frame type. port f47b9e981035c887bda5ae66203e458eb37a5a65 (r37051) original commit message: This adds a new BUILTIN frame type, which supports variable number of arguments for builtins implemented in hand-written native code (we will extend this mechanism to TurboFan builtins at some point). Convert the Math.max and Math.min builtins to construct a BUILTIN frame if required. This does not yet work for C++ builtins, but that'll be the next step. BUG= Committed: https://crrev.com/1e18c55edba4287678cefac4966f3b9f40122f28 Cr-Commit-Position: refs/heads/master@{#37270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/x87/builtins-x87.cc View 4 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 05:54:09 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 06:07:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096283003/1
4 years, 5 months ago (2016-06-27 06:36:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 07:01:02 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 07:02:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e18c55edba4287678cefac4966f3b9f40122f28
Cr-Commit-Position: refs/heads/master@{#37270}

Powered by Google App Engine
This is Rietveld 408576698