Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issue 2096283002: X87: [builtins] Introduce proper Float64Exp operator. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce proper Float64Exp operator. port d5f2ac5e3326f281cbe7ba57464a4b17a9938e37 (r37047) original commit message: Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.exp() as TurboFan builtin and use that operator to also inline Math.exp() into optimized TurboFan functions. BUG= Committed: https://crrev.com/9714c98f6a84e6637b3cd2d6c7b3a59e25b33833 Cr-Commit-Position: refs/heads/master@{#37269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -79 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +10 lines, -58 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 1 chunk +2 lines, -12 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/x87/codegen-x87.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 05:52:13 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 06:07:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096283002/1
4 years, 5 months ago (2016-06-27 06:08:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 06:30:10 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 06:33:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9714c98f6a84e6637b3cd2d6c7b3a59e25b33833
Cr-Commit-Position: refs/heads/master@{#37269}

Powered by Google App Engine
This is Rietveld 408576698