Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2096273002: X87: [wasm] Relocatable Globals. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Relocatable Globals. port 2d1f977c93942f58f0aaf886adb346f4eba5a1ea (r36978) original commit message: Support for relocatable globals, to facilitate compilation before instantiation. BUG= Committed: https://crrev.com/877e428fd9037307e857e9adb98ae646e6a13d99 Cr-Commit-Position: refs/heads/master@{#37266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/assembler-x87.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 03:42:47 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 03:53:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096273002/1
4 years, 5 months ago (2016-06-27 03:54:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 04:15:38 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 04:16:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/877e428fd9037307e857e9adb98ae646e6a13d99
Cr-Commit-Position: refs/heads/master@{#37266}

Powered by Google App Engine
This is Rietveld 408576698