Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2096253002: Remove EventSender from SVGSMILElement (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 2 months ago
Reviewers:
fs
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove EventSender from SVGSMILElement BUG=624697 Committed: https://crrev.com/759a69172d0558751a9623f535920e14429f7a9b Cr-Commit-Position: refs/heads/master@{#422083}

Patch Set 1 #

Patch Set 2 : Use DOMManipulation #

Patch Set 3 : include fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -43 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h View 1 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 1 2 4 chunks +18 lines, -38 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096253002/1
4 years, 5 months ago (2016-06-26 12:47:14 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-26 13:59:06 UTC) #4
hiroshige
Could you take a look?
4 years, 2 months ago (2016-09-30 07:49:32 UTC) #7
fs
lgtm
4 years, 2 months ago (2016-09-30 08:09:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096253002/40001
4 years, 2 months ago (2016-09-30 11:42:24 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 11:47:37 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 11:49:27 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/759a69172d0558751a9623f535920e14429f7a9b
Cr-Commit-Position: refs/heads/master@{#422083}

Powered by Google App Engine
This is Rietveld 408576698