Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2096223002: Convert video-src-invalid* and video-src-none* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-src-invalid* and video-src-none* tests to testharness.js Cleaning up video-src-invalid* and video-src-none* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/b63b47f4b9753783c34028662858b1e7788c3010 Cr-Commit-Position: refs/heads/master@{#402727}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address comments #

Total comments: 2

Patch Set 3 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -154 lines) Patch
M third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html View 1 2 1 chunk +19 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-src-invalid-poster-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-src-invalid-remove.html View 1 chunk +24 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-src-invalid-remove-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-src-none.html View 1 chunk +21 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-src-none-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-25 13:56:33 UTC) #3
ilovebobby906
On 2016/06/25 13:52:02, Srirama wrote: > Description was changed from > > ========== > fix ...
4 years, 6 months ago (2016-06-25 14:10:45 UTC) #5
fs
https://codereview.chromium.org/2096223002/diff/20001/third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html File third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html (right): https://codereview.chromium.org/2096223002/diff/20001/third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html#newcode11 third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html:11: setTimeout(t.step_func_done(function() { Can we guarantee that the poster image ...
4 years, 6 months ago (2016-06-25 16:38:40 UTC) #6
Srirama
https://codereview.chromium.org/2096223002/diff/20001/third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html File third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html (right): https://codereview.chromium.org/2096223002/diff/20001/third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html#newcode11 third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html:11: setTimeout(t.step_func_done(function() { On 2016/06/25 16:38:39, fs wrote: > Can ...
4 years, 5 months ago (2016-06-28 17:02:51 UTC) #7
fs
lgtm https://codereview.chromium.org/2096223002/diff/40001/third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html File third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html (right): https://codereview.chromium.org/2096223002/diff/40001/third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html#newcode13 third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html:13: // With this we can be sure that ...
4 years, 5 months ago (2016-06-28 17:24:03 UTC) #8
Srirama
https://codereview.chromium.org/2096223002/diff/40001/third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html File third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html (right): https://codereview.chromium.org/2096223002/diff/40001/third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html#newcode13 third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html:13: // With this we can be sure that the ...
4 years, 5 months ago (2016-06-28 17:39:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096223002/60001
4 years, 5 months ago (2016-06-28 17:40:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253916)
4 years, 5 months ago (2016-06-28 20:40:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096223002/60001
4 years, 5 months ago (2016-06-29 03:45:37 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-06-29 05:09:00 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 05:10:36 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b63b47f4b9753783c34028662858b1e7788c3010
Cr-Commit-Position: refs/heads/master@{#402727}

Powered by Google App Engine
This is Rietveld 408576698