Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4448)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java

Issue 2096203002: [TTS] Basic Tap Suppression functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added compensation for Quick Answers and rebased. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
index ed0243471b0be652be7405c954e34de94b109e47..5b1424ebe2ca3e7cb1c7c00b86be1b40e27941b2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
@@ -63,7 +63,8 @@ public class ContextualSearchFieldTrial {
// Quick Answers.
private static final String ENABLE_QUICK_ANSWERS = "enable_quick_answers";
- // Triggering suppression.
+ // Tap triggering suppression.
+ private static final String SUPPRESSION_TAPS = "suppression_taps";
// Enables collection of recent scroll seen/unseen histograms.
// TODO(donnd): remove all supporting code once short-lived data collection is done.
private static final String ENABLE_RECENT_SCROLL_COLLECTION = "enable_recent_scroll_collection";
@@ -96,6 +97,7 @@ public class ContextualSearchFieldTrial {
private static Integer sScreenTopSuppressionDps;
private static Boolean sIsBarOverlapCollectionEnabled;
private static Boolean sIsBarOverlapSuppressionEnabled;
+ private static Integer sSuppressionTaps;
/**
* Don't instantiate.
@@ -368,13 +370,31 @@ public class ContextualSearchFieldTrial {
* @return Whether triggering is suppressed by a selection nearly overlapping the normal
* Bar peeking location.
*/
- static boolean isBarOverlapSupressionEnabled() {
+ static boolean isBarOverlapSuppressionEnabled() {
if (sIsBarOverlapSuppressionEnabled == null) {
sIsBarOverlapSuppressionEnabled = getBooleanParam(BAR_OVERLAP_SUPPRESSION_ENABLED);
}
return sIsBarOverlapSuppressionEnabled.booleanValue();
}
+ /**
+ * @return Whether triggering by Tap is suppressed (through a combination of various signals).
+ */
+ static boolean isTapSuppressionEnabled() {
+ return getSuppressionTaps() > 0;
+ }
+
+ /**
+ * @return The suppression threshold, expressed as the number of Taps since the last open where
+ * we start suppressing the UX on Tap.
+ */
+ static int getSuppressionTaps() {
+ if (sSuppressionTaps == null) {
+ sSuppressionTaps = getIntParamValueOrDefault(SUPPRESSION_TAPS, 0);
+ }
+ return sSuppressionTaps.intValue();
+ }
+
// --------------------------------------------------------------------------------------------
// Helpers.
// --------------------------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698