Add functions to DesktopViewInterface

Add functions to DesktopViewInterface

cursorMoved()

Currently there is no function in DesktopViewInterface as callback for cursor
movement while TouchInputHandler triggers transformationChanged() when the
cursor moves. This is OK for current DesktopView but isn't friendly for later
OpenGL DesktopView impl. that doesn't expose repaint function to Java and
triggers repaint in native code when cursor pos or matrix is changed.

cursorVisibilityChanged()

Finished zijiehe@'s TODO. This allows OpenGL DesktopView to get information
about change of cursor visibility.

BUG=385924
Committed: https://crrev.com/983edc7f88fc99a9a3a23eaeb9cbc26df7dafd54
Cr-Commit-Position: refs/heads/master@{#402265}

[Yuwei, 2016-06-25 00:57:52]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-25 00:58:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuwei, 2016-06-25 00:58:15]

yuweih@chromium.org changed reviewers:
+ lambroslambrou@chromium.org, zijiehe@chromium.org

[Yuwei, 2016-06-25 00:58:16]

ptal

[commit-bot: I haz the power, 2016-06-25 01:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-25 01:38:13]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-06-26 21:37:22]

On 2016/06/25 01:38:13, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

lgtm
I think this change is good for a short term solution. I just want to explain my
next step. A new class RenderControl will replace these functions in
DesktopViewInterface to control UI change, such as zooming, moving view port,
moving cursor, etc. This won't impact your open GL logic too much, we just need
to listen to a set of events instead of implement a function. Detail information
can be found at https://goo.gl/MA6zjx, in Refactor Details/RenderController
(changed from UiController).

[Yuwei, 2016-06-27 17:34:28]

On 2016/06/26 21:37:22, Hzj_jie wrote:
> On 2016/06/25 01:38:13, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> lgtm
> I think this change is good for a short term solution. I just want to explain
my
> next step. A new class RenderControl will replace these functions in
> DesktopViewInterface to control UI change, such as zooming, moving view port,
> moving cursor, etc. This won't impact your open GL logic too much, we just
need
> to listen to a set of events instead of implement a function. Detail
information
> can be found at https://goo.gl/MA6zjx, in Refactor Details/RenderController
> (changed from UiController).

Depending on your progress, my CL may be overwritten by yours before I check in
the actual GlDesktopView :) Anyway I think it's still good to commit this CL so
that you won't forget these functions when making RenderControl.

[Yuwei, 2016-06-27 17:34:44]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-06-27 17:35:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 17:35:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 17:35:20]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Lambros, 2016-06-27 18:33:08]

lgtm

https://codereview.chromium.org/2096193002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java
(right):

https://codereview.chromium.org/2096193002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java:46:
void cursorVisibilityChanged();
Do we need separate events for all the different things that can be done to a
cursor?
It can move, it can be shown/hidden, or it can have a new bitmap image (which
you haven't added a notification for). Maybe these could all be covered by a
single cursorChanged() notification?

[Yuwei, 2016-06-27 19:00:34]

On 2016/06/27 18:33:08, Lambros wrote:
> lgtm
> 
>
https://codereview.chromium.org/2096193002/diff/1/remoting/android/java/src/o...
> File
remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java
> (right):
> 
>
https://codereview.chromium.org/2096193002/diff/1/remoting/android/java/src/o...
>
remoting/android/java/src/org/chromium/chromoting/DesktopViewInterface.java:46:
> void cursorVisibilityChanged();
> Do we need separate events for all the different things that can be done to a
> cursor?
> It can move, it can be shown/hidden, or it can have a new bitmap image (which
> you haven't added a notification for). Maybe these could all be covered by a
> single cursorChanged() notification?

My OpenGL implementation will upload the cursor position and transformation
matrix to GPU memory immediately after they are changed, unlike the current
implementation that gets the cursor position and transformation in the painting
loop. So it is good to know what exactly is changed so that the correct
GlRenderer::On???Changed() function can be called. For single cursorChanged()
we may end up uploading some unchanged information to the GPU.

[Yuwei, 2016-06-27 19:00:49]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-06-27 19:03:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 20:07:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-27 20:09:01]

Description was changed from

==========
Add functions to DesktopViewInterface

cursorMoved()

Currently there is no function in DesktopViewInterface as callback for cursor
movement while TouchInputHandler triggers transformationChanged() when the
cursor moves. This is OK for current DesktopView but isn't friendly for later
OpenGL DesktopView impl. that doesn't expose repaint function to Java and
triggers repaint in native code when cursor pos or matrix is changed.

cursorVisibilityChanged()

Finished zijiehe@'s TODO. This allows OpenGL DesktopView to get information
about change of cursor visibility.

BUG=385924
==========

to

==========
Add functions to DesktopViewInterface

cursorMoved()

Currently there is no function in DesktopViewInterface as callback for cursor
movement while TouchInputHandler triggers transformationChanged() when the
cursor moves. This is OK for current DesktopView but isn't friendly for later
OpenGL DesktopView impl. that doesn't expose repaint function to Java and
triggers repaint in native code when cursor pos or matrix is changed.

cursorVisibilityChanged()

Finished zijiehe@'s TODO. This allows OpenGL DesktopView to get information
about change of cursor visibility.

BUG=385924

Committed: https://crrev.com/983edc7f88fc99a9a3a23eaeb9cbc26df7dafd54
Cr-Commit-Position: refs/heads/master@{#402265}
==========

[commit-bot: I haz the power, 2016-06-27 20:09:02]

Patchset 1 (id:??) landed as
https://crrev.com/983edc7f88fc99a9a3a23eaeb9cbc26df7dafd54
Cr-Commit-Position: refs/heads/master@{#402265}