Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Issue 2096183002: DevTools: Added styling to focused checkboxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use default outline and allow focus styling opt-in Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
index 48a123be6190e5f985b221067fab74b695a08a58..aafcbdd356662b75ac255de489c466fb4a5abc8d 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
@@ -1504,6 +1504,18 @@ WebInspector.appendStyle = function(node, cssFile)
this.checkboxElement.style.borderColor = color;
},
+ /**
+ * @param {boolean} focus
+ * @this {Element}
+ */
+ set focusVisible(focus)
lushnikov 2016/07/08 23:01:22 1. let's make this a function (we tend to avoid se
flandy 2016/07/11 18:46:43 1. Using a function causes an issue with the Closu
+ {
+ if (focus)
+ this.checkboxElement.classList.add("dt-checkbox-focus-visible");
lushnikov 2016/07/08 23:01:22 this "if" could be written in a one line: this.ch
flandy 2016/07/11 18:46:43 Done
+ else
+ this.checkboxElement.classList.remove("dt-checkbox-focus-visible");
+ },
+
__proto__: HTMLLabelElement.prototype
});

Powered by Google App Engine
This is Rietveld 408576698