Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(999)

Issue 2096143002: pdfium clang/win: Stop passing /FIIntrin.h (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

pdfium clang/win: Stop passing /FIIntrin.h See https://codereview.chromium.org/2076483002 for a lengthy reasoning. The two mysterious files called out there were in boringssl and nacl, so for pdfium this should be a complete no-op. BUG=chromium:592745 Committed: https://pdfium.googlesource.com/pdfium/+/afe3e4671b3f70e0459487aca89133a746c61797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build_gyp/standalone.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
4 years, 3 months ago (2016-06-24 20:58:48 UTC) #2
Lei Zhang
lgtm
4 years, 3 months ago (2016-06-24 21:48:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096143002/1
4 years, 3 months ago (2016-06-24 21:51:50 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-06-24 22:05:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/afe3e4671b3f70e0459487aca89133a746c6...

Powered by Google App Engine
This is Rietveld 408576698