chrome/browser/ui/views/download/download_shelf_view.h - Issue 209613002: Download shelf autohides on showing in shell, just same as regular open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_shelf_view.h

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the 'user acted' flag into DownloadItemModelData and get rid of SetOpened/SetShown in Download… Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/download/download_item_controller.mm ('K') | « chrome/browser/ui/views/download/download_item_view.cc ('k') | chrome/browser/ui/views/download/download_shelf_view.cc » ('j') | content/public/test/mock_download_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_shelf_view.h

diff --git a/chrome/browser/ui/views/download/download_shelf_view.h b/chrome/browser/ui/views/download/download_shelf_view.h

index 8f4f22e0402e9f13a4ff61c7ba8d76016ef9ce45..4bc454f031c59aa3547753002a1ff1030ce28126 100644

--- a/chrome/browser/ui/views/download/download_shelf_view.h

+++ b/chrome/browser/ui/views/download/download_shelf_view.h

@@ -50,7 +50,10 @@ class DownloadShelfView : public views::AccessiblePaneView,

virtual ~DownloadShelfView();

// Sent from the DownloadItemView when the user opens an item.

- void OpenedDownload(DownloadItemView* view);

+ void OnDownloadOpened(DownloadItemView* view);

+ // Sent from the DownloadItemView when the user shows item in shell.

+ void OnDownloadShown(DownloadItemView* view);

// Returns the relevant containing object that can load pages.

// i.e. the |browser_|.