chrome/browser/ui/cocoa/download/download_item_mac.mm - Issue 209613002: Download shelf autohides on showing in shell, just same as regular open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_item_mac.mm

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the 'user acted' flag into DownloadItemModelData and get rid of SetOpened/SetShown in Download… Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/download/download_item_controller.mm ('K') | « chrome/browser/ui/cocoa/download/download_item_mac.h ('k') | chrome/browser/ui/cocoa/download/download_shelf_controller.h » ('j') | content/public/test/mock_download_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_item_mac.mm

diff --git a/chrome/browser/ui/cocoa/download/download_item_mac.mm b/chrome/browser/ui/cocoa/download/download_item_mac.mm

index 3efffe17d004d0b8b376dcdb01c28f49cf316117..e749adea5c243c35e123982ebb9c06fd8b06d6e1 100644

--- a/chrome/browser/ui/cocoa/download/download_item_mac.mm

+++ b/chrome/browser/ui/cocoa/download/download_item_mac.mm

@@ -71,6 +71,11 @@ void DownloadItemMac::OnDownloadOpened(content::DownloadItem* download) {

[item_controller_ downloadWasOpened];

}

+void DownloadItemMac::OnDownloadShown(content::DownloadItem* download) {

+ DCHECK_EQ(download, download_model_.download());

+ [item_controller_ downloadWasShown];

void DownloadItemMac::LoadIcon() {

IconManager* icon_manager = g_browser_process->icon_manager();

if (!icon_manager) {