Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5814)

Unified Diff: chrome/browser/ui/cocoa/download/download_item_controller.mm

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the 'user acted' flag into DownloadItemModelData and get rid of SetOpened/SetShown in Download… Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_item_controller.mm
diff --git a/chrome/browser/ui/cocoa/download/download_item_controller.mm b/chrome/browser/ui/cocoa/download/download_item_controller.mm
index 430ecbc3fd7b1a4b0b5f3c85bdb6fa187f9b25df..0c326d76560f2ff452f055a364026d61c8d5207a 100644
--- a/chrome/browser/ui/cocoa/download/download_item_controller.mm
+++ b/chrome/browser/ui/cocoa/download/download_item_controller.mm
@@ -239,6 +239,10 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {
[shelf_ downloadWasOpened:self];
}
+- (void)downloadWasShown {
+ [shelf_ downloadWasShown:self];
+}
+
- (IBAction)handleButtonClick:(id)sender {
NSEvent* event = [NSApp currentEvent];
DownloadItem* download = [self download];
@@ -261,6 +265,10 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {
return bridge_->download_model()->download();
}
+- (DownloadItemModel*)downloadItemModel{
+ return bridge_->download_model();
asanka 2014/06/12 21:08:47 This method shouldn't be necessary. If you have a
+}
+
- (ui::MenuModel*)contextMenuModel {
return menuBridge_->GetMenuModel();
}

Powered by Google App Engine
This is Rietveld 408576698