chrome/browser/ui/cocoa/download/download_shelf_controller.h - Issue 209613002: Download shelf autohides on showing in shell, just same as regular open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_controller.h

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added browser and unit tests. Renamed 'UserActed' to 'OpenedOrShown'. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/download/download_item_mac.mm ('k') | chrome/browser/ui/cocoa/download/download_shelf_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_shelf_controller.h

diff --git a/chrome/browser/ui/cocoa/download/download_shelf_controller.h b/chrome/browser/ui/cocoa/download/download_shelf_controller.h

index f124bb8f500d59c847c6e3594c4080ee6e59bd7b..9546fbf9fee9b073e4b413633698de26ae6dc7bc 100644

--- a/chrome/browser/ui/cocoa/download/download_shelf_controller.h

+++ b/chrome/browser/ui/cocoa/download/download_shelf_controller.h

@@ -120,8 +120,9 @@ class PageNavigator;

// Remove a download, possibly via clearing browser data.

- (void)remove:(DownloadItemController*)download;

-// Called by individual item controllers when their downloads are opened.

-- (void)downloadWasOpened:(DownloadItemController*)download;

+// Called by individual item controllers when their downloads are opened or

+// shown.

+- (void)downloadWasOpenedOrShown:(DownloadItemController*)download;

// Return the height of the download shelf.

- (float)height;