chrome/browser/ntp_snippets/fake_download_item.h - Issue 209613002: Download shelf autohides on showing in shell, just same as regular open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ntp_snippets/fake_download_item.h

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added browser and unit tests. Renamed 'UserActed' to 'OpenedOrShown'. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | chrome/browser/ntp_snippets/fake_download_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ntp_snippets/fake_download_item.h

diff --git a/chrome/browser/ntp_snippets/fake_download_item.h b/chrome/browser/ntp_snippets/fake_download_item.h

index 7efc70fb9dae18e9622093bebba8852d8c4bb917..fd5e8d70ef172fa07b9cd20db8c23ab3cd40d79b 100644

--- a/chrome/browser/ntp_snippets/fake_download_item.h

+++ b/chrome/browser/ntp_snippets/fake_download_item.h

@@ -117,7 +117,6 @@ class FakeDownloadItem : public content::DownloadItem {

void OnContentCheckCompleted(

content::DownloadDangerType danger_type) override;

void SetOpenWhenComplete(bool open) override;

- void SetOpened(bool opened) override;

void SetDisplayName(const base::FilePath& name) override;

std::string DebugString(bool verbose) const override;