Download shelf autohides on showing in shell, just same as regular open

content/browser/download/download_item_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // File method ordering: Methods in this file are in the same order as
 // in download_item_impl.h, with the following exception: The public
 // interface Start is placed in chronological order with the other
 // (private) routines that together define a DownloadItem's state
 // transitions as the download progresses.  See "Download progression
 // cascade" later in this file.
@@ skipping 136 matching lines @@
       delegate_(delegate),
       is_paused_(false),
       auto_resume_count_(0),
       open_when_complete_(false),
       file_externally_removed_(false),
       auto_opened_(false),
       is_temporary_(false),
       all_data_saved_(state == COMPLETE),
       destination_error_(content::DOWNLOAD_INTERRUPT_REASON_NONE),
       opened_(opened),
+      shownWhenComplete_(false),

[asanka, 2014/05/14 18:40:59]

Nit: Use hacker_style_.

[DukeXar, 2014/06/06 15:07:13]

Removed

       delegate_delayed_complete_(false),
       bound_net_log_(bound_net_log),
       weak_ptr_factory_(this) {
   delegate_->Attach();
   DCHECK_NE(IN_PROGRESS_INTERNAL, state_);
   Init(false /* not actively downloading */, SRC_HISTORY_IMPORT);
 }
 
 // Constructing for a regular download:
 DownloadItemImpl::DownloadItemImpl(
@@ skipping 31 matching lines @@
       delegate_(delegate),
       is_paused_(false),
       auto_resume_count_(0),
       open_when_complete_(false),
       file_externally_removed_(false),
       auto_opened_(false),
       is_temporary_(!info.save_info->file_path.empty()),
       all_data_saved_(false),
       destination_error_(content::DOWNLOAD_INTERRUPT_REASON_NONE),
       opened_(false),
+      shownWhenComplete_(false),
       delegate_delayed_complete_(false),
       bound_net_log_(bound_net_log),
       weak_ptr_factory_(this) {
   delegate_->Attach();
   Init(true /* actively downloading */, SRC_ACTIVE_DOWNLOAD);
 
   // Link the event sources.
   bound_net_log_.AddEvent(
       net::NetLog::TYPE_DOWNLOAD_URL_REQUEST,
       info.request_bound_net_log.source().ToEventParametersCallback());
@@ skipping 35 matching lines @@
       delegate_(delegate),
       is_paused_(false),
       auto_resume_count_(0),
       open_when_complete_(false),
       file_externally_removed_(false),
       auto_opened_(false),
       is_temporary_(false),
       all_data_saved_(false),
       destination_error_(content::DOWNLOAD_INTERRUPT_REASON_NONE),
       opened_(false),
+      shownWhenComplete_(false),
       delegate_delayed_complete_(false),
       bound_net_log_(bound_net_log),
       weak_ptr_factory_(this) {
   delegate_->Attach();
   Init(true /* actively downloading */, SRC_SAVE_PAGE_AS);
 }
 
 DownloadItemImpl::~DownloadItemImpl() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
@@ skipping 190 matching lines @@
   delegate_->CheckForFileRemoval(this);
   RecordOpen(GetEndTime(), !GetOpened());
   opened_ = true;
   FOR_EACH_OBSERVER(Observer, observers_, OnDownloadOpened(this));
   delegate_->OpenDownload(this);
 }
 
 void DownloadItemImpl::ShowDownloadInShell() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
+  if (!CanShowInFolder())
+    return;
+
+  // Marking the download as shown if it is complete and user opened it
+  // in shell
+  if (state_ == COMPLETE_INTERNAL)
+    shownWhenComplete_ = true;
+
+  delegate_->CheckForFileRemoval(this);
+  FOR_EACH_OBSERVER(Observer, observers_, OnDownloadShown(this));
   delegate_->ShowDownloadInShell(this);
 }
 
 uint32 DownloadItemImpl::GetId() const {
   return download_id_;
 }
 
 DownloadItem::DownloadState DownloadItemImpl::GetState() const {
   return InternalToExternalState(state_);
 }
@@ skipping 270 matching lines @@
 }
 
 bool DownloadItemImpl::GetAutoOpened() {
   return auto_opened_;
 }
 
 bool DownloadItemImpl::GetOpened() const {
   return opened_;
 }
 
+bool DownloadItemImpl::GetShownWhenComplete() const {
+  return shownWhenComplete_;
+}
+
 BrowserContext* DownloadItemImpl::GetBrowserContext() const {
   return delegate_->GetBrowserContext();
 }
 
 WebContents* DownloadItemImpl::GetWebContents() const {
   // TODO(rdsmith): Remove null check after removing GetWebContents() from
   // paths that might be used by DownloadItems created from history import.
   // Currently such items have null request_handle_s, where other items
   // (regular and SavePackage downloads) have actual objects off the pointer.
   if (request_handle_)
@@ skipping 15 matching lines @@
 }
 
 void DownloadItemImpl::SetIsTemporary(bool temporary) {
   is_temporary_ = temporary;
 }
 
 void DownloadItemImpl::SetOpened(bool opened) {
   opened_ = opened;
 }
 
+void DownloadItemImpl::SetShownWhenComplete(bool shown) {
+  shownWhenComplete_ = shown;
+}
+
 void DownloadItemImpl::SetDisplayName(const base::FilePath& name) {
   display_name_ = name;
 }
 
 std::string DownloadItemImpl::DebugString(bool verbose) const {
   std::string description =
       base::StringPrintf("{ id = %d"
                          " state = %s",
                          download_id_,
                          DebugDownloadStateString(state_));
@@ skipping 988 matching lines @@
     case RESUME_MODE_USER_CONTINUE:
       return "USER_CONTINUE";
     case RESUME_MODE_USER_RESTART:
       return "USER_RESTART";
   }
   NOTREACHED() << "Unknown resume mode " << mode;
   return "unknown";
 }
 
 }  // namespace content