Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/ui/views/download/download_shelf_view.h

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implement a separate callbacks flow for 'shown in shell' event to not mix with 'opened' Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 public views::ButtonListener, 45 public views::ButtonListener,
46 public views::LinkListener, 46 public views::LinkListener,
47 public views::MouseWatcherListener { 47 public views::MouseWatcherListener {
48 public: 48 public:
49 DownloadShelfView(Browser* browser, BrowserView* parent); 49 DownloadShelfView(Browser* browser, BrowserView* parent);
50 virtual ~DownloadShelfView(); 50 virtual ~DownloadShelfView();
51 51
52 // Sent from the DownloadItemView when the user opens an item. 52 // Sent from the DownloadItemView when the user opens an item.
53 void OpenedDownload(DownloadItemView* view); 53 void OpenedDownload(DownloadItemView* view);
54 54
55 // Sent from the DownloadItemView when the user shows item in shell.
56 void ShownDownload(DownloadItemView* view);
57
55 // Returns the relevant containing object that can load pages. 58 // Returns the relevant containing object that can load pages.
56 // i.e. the |browser_|. 59 // i.e. the |browser_|.
57 content::PageNavigator* GetNavigator(); 60 content::PageNavigator* GetNavigator();
58 61
59 // Returns the parent_. 62 // Returns the parent_.
60 BrowserView* get_parent() { return parent_; } 63 BrowserView* get_parent() { return parent_; }
61 64
62 // Implementation of View. 65 // Implementation of View.
63 virtual gfx::Size GetPreferredSize() OVERRIDE; 66 virtual gfx::Size GetPreferredSize() OVERRIDE;
64 virtual void Layout() OVERRIDE; 67 virtual void Layout() OVERRIDE;
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 154
152 // The window this shelf belongs to. 155 // The window this shelf belongs to.
153 BrowserView* parent_; 156 BrowserView* parent_;
154 157
155 views::MouseWatcher mouse_watcher_; 158 views::MouseWatcher mouse_watcher_;
156 159
157 DISALLOW_COPY_AND_ASSIGN(DownloadShelfView); 160 DISALLOW_COPY_AND_ASSIGN(DownloadShelfView);
158 }; 161 };
159 162
160 #endif // CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_ 163 #endif // CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698