Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h

Issue 2096103003: Move weave packet to common location b/t generator and receiver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: renamed weave_packet to weave_defines Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h
diff --git a/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h b/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h
index eb3204ca91bab4fc900e096dfb2f576225f34363..fa70ccd24564319f94e893fef10978d8c7b0d218 100644
--- a/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h
+++ b/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h
@@ -12,9 +12,12 @@
#include <string>
#include <vector>
+#include "components/proximity_auth/ble/bluetooth_low_energy_weave_defines.h"
#include "build/build_config.h"
namespace proximity_auth {
+namespace weave {
+
// Generates the messages sent using the uWeave protocol.
class BluetoothLowEnergyWeavePacketGenerator {
public:
@@ -35,34 +38,12 @@ class BluetoothLowEnergyWeavePacketGenerator {
static Factory* factory_instance_;
};
- // Determine whether a packet is a control packet or a data packet.
- enum PacketType { DATA = 0x00, CONTROL = 0x01 };
-
- // Identify the action intended by the control packet.
- enum ControlCommand {
- CONNECTION_REQUEST = 0x00,
- CONNECTION_RESPONSE = 0x01,
- CONNECTION_CLOSE = 0x02
- };
-
- // Sent with the ConnectionClose control packet.
- // Identify why the client/server wished to close the connection.
- enum ReasonForClose {
- CLOSE_WITHOUT_ERROR = 0x00,
- UNKNOWN_ERROR = 0x01,
- NO_COMMON_VERSION_SUPPORTED = 0x02,
- RECEIVED_PACKET_OUT_OF_SEQUENCE = 0x03,
- APPLICATION_ERROR = 0x80
- };
-
- typedef std::vector<uint8_t> Packet;
-
Packet CreateConnectionRequest();
Packet CreateConnectionResponse();
Packet CreateConnectionClose(ReasonForClose reason_for_close);
// Packet size must be greater than or equal to 20.
- void SetMaxPacketSize(uint32_t size);
+ void SetMaxPacketSize(uint16_t size);
// Will crash if message is empty.
std::vector<Packet> EncodeDataMessage(std::string message);
@@ -80,12 +61,14 @@ class BluetoothLowEnergyWeavePacketGenerator {
// The default max packet length is 20 unless SetDataPacketLength() is called
// and specified otherwise.
- uint32_t max_packet_size_;
+ uint16_t max_packet_size_;
// Counter for the number of packets sent, starting at 0.
- uint32_t next_packet_counter_;
+ uint8_t next_packet_counter_;
};
+} // namespace weave
+
} // namespace proximity_auth
#endif // COMPONENTS_PROXIMITY_AUTH_BLE_BLUETOOTH_LOW_ENERGY_WEAVE_PACKET_GENERATOR_H_

Powered by Google App Engine
This is Rietveld 408576698