Analyzer support for `@factory` methods (linter#253).

Analyzer support for `@factory` methods (linter#253).

R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/linter/issues/253.
Committed: https://github.com/dart-lang/sdk/commit/f4c2a0faba40c89a0f15a8307f12be2ffc3bc5b9

[pquitslund, 2016-06-24 19:32:55]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-06-24 21:04:00]

lgtm

https://codereview.chromium.org/2096103002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2096103002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:694: if (returnType == null ||
returnType.type is VoidType) {
Checking for `void` makes sense; not sure about checking for `null`. Won't the
latter produce other lints (always use type annotations)?

[pquitslund, 2016-06-24 21:40:35]

Thanks!

https://codereview.chromium.org/2096103002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2096103002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:694: if (returnType == null ||
returnType.type is VoidType) {
On 2016/06/24 21:04:00, Brian Wilkerson wrote:
> Checking for `void` makes sense; not sure about checking for `null`. Won't the
> latter produce other lints (always use type annotations)?

Good point.   There could be a pile up, assuming that lint is enabled.  (Of
course, in this case, I think we can rest assured that it will be.)  I'll remove
the check for now.

[pquitslund, 2016-06-24 21:41:06]

Description was changed from

==========
Analyzer support for `@factory` methods (linter#253).

Fixes: https://github.com/dart-lang/linter/issues/253.
==========

to

==========
Analyzer support for `@factory` methods (linter#253).

R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/linter/issues/253.
Committed:
https://github.com/dart-lang/sdk/commit/f4c2a0faba40c89a0f15a8307f12be2ffc3bc5b9
==========

[pquitslund, 2016-06-24 21:41:07]

Committed patchset #2 (id:20001) manually as
f4c2a0faba40c89a0f15a8307f12be2ffc3bc5b9 (presubmit successful).