Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3003)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 2096073002: Record how often we end up in Chrome from external navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add null check for activity info. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index 4b92ddc6b93faf741134053dc1181254b5ca998b..a85a313a1cd723db76428f9943062202d25d8b41 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -1001,9 +1001,14 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {
}
@Override
- public int countSpecializedHandlers(List<ResolveInfo> infos) {
+ public int countSpecializedHandlers(List<ResolveInfo> resolveInfos) {
+ return getSpecializedHandlers(resolveInfos).size();
+ }
+
+ private ArrayList<String> getSpecializedHandlers(List<ResolveInfo> infos) {
+ ArrayList<String> result = new ArrayList<>();
if (infos == null) {
- return 0;
+ return result;
}
int count = 0;
for (ResolveInfo info : infos) {
@@ -1013,10 +1018,10 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {
|| packageName.equals(NATIVE_APP_PACKAGE_NAME)
|| packageName.equals(WEBAPK_PACKAGE_NAME)
|| packageName.equals(WEBAPK_WITH_NATIVE_APP_PACKAGE_NAME)) {
- ++count;
+ result.add(packageName);
}
}
- return count;
+ return result;
}
@Override
@@ -1082,6 +1087,10 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {
}
@Override
+ public void maybeRecordAppHandlersInIntent(Intent intent, List<ResolveInfo> info) {
+ }
+
+ @Override
public boolean isChromeAppInForeground() {
return mIsChromeAppInForeground;
}

Powered by Google App Engine
This is Rietveld 408576698