Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2096043002: bluetooth: Mark TestBluetoothAdapterObserver accessor methods const (Closed)

Created:
4 years, 6 months ago by ortuno
Modified:
4 years, 5 months ago
Reviewers:
scheib
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-characteristic-value-changed
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Mark TestBluetoothAdapterObserver accessor methods const There is no reason why the methods should be non-const. More importantly it allows us to pass the observer as a const reference to lambdas or callbacks that need to check its properties. BUG=580406 Committed: https://crrev.com/084aec7f79d92169449f435c51aa6f562413b323 Cr-Commit-Position: refs/heads/master@{#403380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -33 lines) Patch
M device/bluetooth/test/test_bluetooth_adapter_observer.h View 1 chunk +47 lines, -33 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
ortuno
scheib: PTAL. This is a follow up patch of http://crrev.com/2085293002 that made a single function ...
4 years, 6 months ago (2016-06-24 18:19:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096043002/1
4 years, 6 months ago (2016-06-24 18:19:51 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/235219)
4 years, 6 months ago (2016-06-24 18:39:09 UTC) #6
scheib
LGTM
4 years, 5 months ago (2016-06-30 22:10:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096043002/1
4 years, 5 months ago (2016-06-30 22:14:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 01:09:58 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 01:10:01 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 01:12:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/084aec7f79d92169449f435c51aa6f562413b323
Cr-Commit-Position: refs/heads/master@{#403380}

Powered by Google App Engine
This is Rietveld 408576698