Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2095993003: MD Settings: find language buttons more specifically in tests (Closed)

Created:
4 years, 6 months ago by michaelpg
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: find language buttons more specifically in tests +clang-format Committed: https://crrev.com/0dc6a561aa44827d8b65e072c20c033b6f4857b3 Cr-Commit-Position: refs/heads/master@{#401941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/test/data/webui/settings/languages_page_browsertest.js View 5 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
michaelpg
4 years, 6 months ago (2016-06-24 17:20:10 UTC) #3
Dan Beam
lgtm
4 years, 6 months ago (2016-06-24 19:24:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095993003/1
4 years, 6 months ago (2016-06-24 19:35:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 19:44:20 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 19:46:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dc6a561aa44827d8b65e072c20c033b6f4857b3
Cr-Commit-Position: refs/heads/master@{#401941}

Powered by Google App Engine
This is Rietveld 408576698