Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2095973002: Don't create m_style for option element in display:none subtree. (Closed)

Created:
4 years, 6 months ago by rune
Modified:
4 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't create m_style for option element in display:none subtree. Instead create a ComputedStyle on demand in rare data like we do for other display:none elements. This caused out-of-date computed style for option elements in display:none subtrees because recalcOwnStyle is skipped for elements without a parentComputedStyle(). R=tkent@chromium.org BUG=621965 Committed: https://crrev.com/91a68cd74e8fb768959d8ddac8b51eb91585d8c3 Cr-Commit-Position: refs/heads/master@{#402095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/forms/select/option-display-none-computed-style.html View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095973002/1
4 years, 6 months ago (2016-06-24 13:44:17 UTC) #2
rune
ptal
4 years, 6 months ago (2016-06-24 13:51:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 14:57:50 UTC) #5
tkent
lgtm
4 years, 5 months ago (2016-06-27 00:25:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095973002/1
4 years, 5 months ago (2016-06-27 00:25:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 01:36:10 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 01:38:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91a68cd74e8fb768959d8ddac8b51eb91585d8c3
Cr-Commit-Position: refs/heads/master@{#402095}

Powered by Google App Engine
This is Rietveld 408576698