Refactor CreateApiFunction

Refactor CreateApiFunction

BUG=

Committed: https://crrev.com/705574970f3899a6eda0c61130c8c31693df4039
Cr-Commit-Position: refs/heads/master@{#37290}

[Toon Verwaest, 2016-06-24 11:35:24]

verwaest@chromium.org changed reviewers:
+ jochen@chromium.org

[Toon Verwaest, 2016-06-24 11:35:25]

ptal

[jochen (gone - plz use gerrit), 2016-06-24 11:50:22]

what's the goal?

[Toon Verwaest, 2016-06-24 12:32:22]

With this particular CL, just simplify the code.

[jochen (gone - plz use gerrit), 2016-06-24 13:35:45]

On 2016/06/24 at 12:32:22, verwaest wrote:
> With this particular CL, just simplify the code.

Might be worthwhile to file a tracking bug for all those costs

lgtm

[Toon Verwaest, 2016-06-24 15:39:39]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-06-24 15:39:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 16:24:36]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Toon Verwaest, 2016-06-27 11:42:32]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-06-27 11:42:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2095953002/#ps20001
(title: "Create the template instantiation cache early enough")

[commit-bot: I haz the power, 2016-06-27 11:42:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 12:16:06]

Description was changed from

==========
Refactor CreateApiFunction

BUG=
==========

to

==========
Refactor CreateApiFunction

BUG=

Committed: https://crrev.com/705574970f3899a6eda0c61130c8c31693df4039
Cr-Commit-Position: refs/heads/master@{#37290}
==========

[commit-bot: I haz the power, 2016-06-27 12:16:07]

Patchset 2 (id:??) landed as
https://crrev.com/705574970f3899a6eda0c61130c8c31693df4039
Cr-Commit-Position: refs/heads/master@{#37290}

[Michael Achenbach, 2016-06-27 17:32:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2099983004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Changes a layout test. Please rebase
upstream if intended:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Michael Achenbach, 2016-06-27 17:37:12]

bindings/blink-in-js-asan-crash.html also crashes. See e.g. output:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Mac/builds/549...

05:40:47.156 10154 worker/1 bindings/blink-in-js-asan-crash.html output stderr
lines:
05:40:47.156 10154   1   0x10bc856db v8::V8::ToLocalEmpty()
05:40:47.156 10154   2   0x10d7051ce
blink::V8PerContextData::V8PerContextData(v8::Local<v8::Context>)