🎊 Have build_config targets depend only on other build_config targets

Have build_config targets depend only on other build_config targets

This works by having android target names follow a naming convention.
If a target name matches, then it is assumed to have a .build_config file.
gn gen will raise an error if it doesn't. Likewise, if a target name
does not match the filters, but does create a .build_config file, gn gen
will fail on an assert.

This change adds a bunch of naming-convention exceptions, which will
be addressed in subsequent commits.

Finally, why make this change? This allows all .build_config targets to be
generated in just a few seconds, which will allow fast generation of
build.gradle files for Android Studio integration.

BUG=620034
Committed: https://crrev.com/1029ca88161324eff7a62b1e2eecc84d5acf0f6c
Cr-Commit-Position: refs/heads/master@{#402934}

[agrieve, 2016-06-24 13:23:47]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 13:24:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2095913003/1

[commit-bot: I haz the power, 2016-06-24 13:39:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 13:39:28]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[agrieve, 2016-06-24 14:42:52]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 14:43:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 14:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 14:59:21]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[agrieve, 2016-06-24 17:28:40]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 17:29:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 18:25:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 18:25:35]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-06-24 19:31:00]

Description was changed from

==========
Have build_config targets depend only on other build_config targets

BUG=620034
==========

to

==========
Have build_config targets depend only on other build_config targets

This works by having android target names follow a naming convention.
If a target name matches, then it is assumed to have a .build_config file.
gn gen will raise an error if it doesn't. Likewise, if a target name
does not match the filters, but does create a .build_config file, gn gen
will fail on an assert.

This change adds a bunch of naming-convention exceptions, which will
be addressed in subsequent commits.

Finally, why make this change? This allows all .build_config targets to be
generated in just a few seconds, which will allow fast generation of
build.gradle files for Android Studio integration.

BUG=620034
==========

[agrieve, 2016-06-24 19:31:00]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[agrieve, 2016-06-24 19:38:31]

On 2016/06/24 18:25:35, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

[agrieve, 2016-06-24 19:39:01]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[agrieve, 2016-06-24 19:39:30]

On 2016/06/24 19:38:31, agrieve wrote:
> On 2016/06/24 18:25:35, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.

[agrieve, 2016-06-28 14:51:13]

agrieve@chromium.org changed reviewers:
- pkotwicz@chromium.org

[agrieve, 2016-06-28 14:51:48]

On 2016/06/24 19:39:30, agrieve wrote:
> On 2016/06/24 19:38:31, agrieve wrote:
> > On 2016/06/24 18:25:35, commit-bot: I haz the power wrote:
> > > Dry run: This issue passed the CQ dry run.

bump

[brettw, 2016-06-29 17:44:06]

lgtm

[agrieve, 2016-06-29 19:45:38]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-06-29 19:46:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 21:08:47]

Description was changed from

==========
Have build_config targets depend only on other build_config targets

This works by having android target names follow a naming convention.
If a target name matches, then it is assumed to have a .build_config file.
gn gen will raise an error if it doesn't. Likewise, if a target name
does not match the filters, but does create a .build_config file, gn gen
will fail on an assert.

This change adds a bunch of naming-convention exceptions, which will
be addressed in subsequent commits.

Finally, why make this change? This allows all .build_config targets to be
generated in just a few seconds, which will allow fast generation of
build.gradle files for Android Studio integration.

BUG=620034
==========

to

==========
Have build_config targets depend only on other build_config targets

This works by having android target names follow a naming convention.
If a target name matches, then it is assumed to have a .build_config file.
gn gen will raise an error if it doesn't. Likewise, if a target name
does not match the filters, but does create a .build_config file, gn gen
will fail on an assert.

This change adds a bunch of naming-convention exceptions, which will
be addressed in subsequent commits.

Finally, why make this change? This allows all .build_config targets to be
generated in just a few seconds, which will allow fast generation of
build.gradle files for Android Studio integration.

BUG=620034
==========

[commit-bot: I haz the power, 2016-06-29 21:08:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 21:09:05]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 21:10:24]

Description was changed from

==========
Have build_config targets depend only on other build_config targets

This works by having android target names follow a naming convention.
If a target name matches, then it is assumed to have a .build_config file.
gn gen will raise an error if it doesn't. Likewise, if a target name
does not match the filters, but does create a .build_config file, gn gen
will fail on an assert.

This change adds a bunch of naming-convention exceptions, which will
be addressed in subsequent commits.

Finally, why make this change? This allows all .build_config targets to be
generated in just a few seconds, which will allow fast generation of
build.gradle files for Android Studio integration.

BUG=620034
==========

to

==========
Have build_config targets depend only on other build_config targets

This works by having android target names follow a naming convention.
If a target name matches, then it is assumed to have a .build_config file.
gn gen will raise an error if it doesn't. Likewise, if a target name
does not match the filters, but does create a .build_config file, gn gen
will fail on an assert.

This change adds a bunch of naming-convention exceptions, which will
be addressed in subsequent commits.

Finally, why make this change? This allows all .build_config targets to be
generated in just a few seconds, which will allow fast generation of
build.gradle files for Android Studio integration.

BUG=620034

Committed: https://crrev.com/1029ca88161324eff7a62b1e2eecc84d5acf0f6c
Cr-Commit-Position: refs/heads/master@{#402934}
==========

[commit-bot: I haz the power, 2016-06-29 21:10:26]

Patchset 3 (id:??) landed as
https://crrev.com/1029ca88161324eff7a62b1e2eecc84d5acf0f6c
Cr-Commit-Position: refs/heads/master@{#402934}

[Pete Williamson, 2016-06-29 22:09:17]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2110943002/ by petewil@chromium.org.

The reason for reverting is: Sheriff: reverting on suspicion of breaking the
android build.

It looks like the apk packaging step fails when a required component is not
found. This change looked like a likely culprit since it changes the naming
conventions, and the problem was file not found.

Link to failed build here:
https://build.chromium.org/p/chromium/builders/Android/builds/58342

Relevant section of build logs here:
FAILED: gen/android_webview/system_webview_apk__create_incremental__package.d
gen/android_webview/system_webview_apk/system_webview_apk.apk_intermediates_incremental.unfinished.apk

python ../../build/android/gyp/apkbuilder.py --depfile
gen/android_webview/system_webview_apk__create_incremental__package.d
--resource-apk=gen/android_webview/system_webview_apk/system_webview_apk.apk_intermediates_incremental.ap_
--output-apk=gen/android_webview/system_webview_apk/system_webview_apk.apk_intermediates_incremental.unfinished.apk
--assets=@FileArg\(gen/android_webview/system_webview_apk.build_config:assets\)
--uncompressed-assets=@FileArg\(gen/android_webview/system_webview_apk.build_config:uncompressed_assets\)
--dex-file=gen/build/android/incremental_install/bootstrap.dex
--android-abi=armeabi-v7a
--native-lib-placeholders=\[\"libfix.crbug.384638.so\"\]
Traceback (most recent call last):
  File "../../build/android/gyp/apkbuilder.py", line 311, in <module>
    main(sys.argv[1:])
  File "../../build/android/gyp/apkbuilder.py", line 307, in main
    depfile_deps=depfile_deps)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py",
line 527, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py",
line 63, in CallAndRecordIfStale
    new_metadata.AddFile(path, _Md5ForPath(path))
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py",
line 381, in _Md5ForPath
    _UpdateMd5ForFile(md5, path)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py",
line 362, in _UpdateMd5ForFile
    with open(path, 'rb') as infile:
IOError: [Errno 2] No such file or directory: u'snapshot_blob.bin'
[34308/48394] ACTION
//android_webview/test:android_webview_apk__create_incremental__package(//build/toolchain/android:arm)
FAILED:
gen/android_webview/test/android_webview_apk__create_incremental__package.d
gen/android_webview/test/android_webview_apk/android_webview_apk.apk_intermediates_incremental.unfinished.apk

python ../../build/android/gyp/apkbuilder.py --depfile
gen/android_webview/test/android_webview_apk__create_incremental__package.d
--resource-apk=gen/android_webview/test/android_webview_apk/android_webview_apk.apk_intermediates_incremental.ap_
--output-apk=gen/android_webview/test/android_webview_apk/android_webview_apk.apk_intermediates_incremental.unfinished.apk
--assets=@FileArg\(gen/android_webview/test/android_webview_apk.build_config:assets\)
--uncompressed-assets=@FileArg\(gen/android_webview/test/android_webview_apk.build_config:uncompressed_assets\)
--dex-file=gen/build/android/incremental_install/bootstrap.dex
--android-abi=armeabi-v7a
--native-lib-placeholders=\[\"libfix.crbug.384638.so\"\]
Traceback (most recent call last):
  File "../../build/android/gyp/apkbuilder.py", line 311, in <module>
    main(sys.argv[1:])
  File "../../build/android/gyp/apkbuilder.py", line 307, in main
    depfile_deps=depfile_deps)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/build_utils.py",
line 527, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py",
line 63, in CallAndRecordIfStale
    new_metadata.AddFile(path, _Md5ForPath(path))
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py",
line 381, in _Md5ForPath
    _UpdateMd5ForFile(md5, path)
  File "/b/build/slave/Android/build/src/build/android/gyp/util/md5_check.py",
line 362, in _UpdateMd5ForFile
    with open(path, 'rb') as infile:
IOError: [Errno 2] No such file or directory: u'snapshot_blob.bin'.