Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tests/compiler/dart2js/semantic_visitor_test_send_data.dart

Issue 2095883002: Update semantic_visitor_send_data to reflect the current state. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/semantic_visitor_test_send_data.dart
diff --git a/tests/compiler/dart2js/semantic_visitor_test_send_data.dart b/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
index b72e47964986159be3b02dc0d15ef125e501db33..5ee48ffde19ebbccb6aee9b8935618c58733d39d 100644
--- a/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
+++ b/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
@@ -2702,8 +2702,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
const Visit(VisitKind.VISIT_SUPER_FIELD_SETTER_COMPOUND,
getter: 'field(A#a)', setter: 'setter(B#a)',
operator: '+=', rhs: '42')),
- // TODO(johnniwinther): Enable this when dart2js supports shadow setters.
- /*const Test.clazz(
+ const Test.clazz(
'''
class A {
var a;
@@ -2716,9 +2715,12 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() => super.a += 42;
}
''',
- const Visit(VisitKind.VISIT_SUPER_FIELD_FIELD_COMPOUND,
- getter: 'field(B#a)', setter: 'field(A#a)',
- operator: '+=', rhs: '42')),*/
+ // TODO(johnniwinther): Change this to
+ // [VISIT_SUPER_FIELD_FIELD_COMPOUND] when dart2js supports shadow
+ // setters.
+ const Visit(VisitKind.VISIT_SUPER_FINAL_FIELD_COMPOUND,
+ element: 'field(B#a)',
+ operator: '+=', rhs: '42')),
const Test.clazz(
'''
class B {
@@ -4437,8 +4439,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
const Visit(VisitKind.VISIT_SUPER_FIELD_SETTER_SET_IF_NULL,
getter: 'field(A#a)', setter: 'setter(B#a)',
rhs: '42')),
- // TODO(johnniwinther): Enable this when dart2js supports shadow setters.
- /*const Test.clazz(
+ const Test.clazz(
'''
class A {
var a;
@@ -4451,9 +4452,12 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() => super.a ??= 42;
}
''',
- const Visit(VisitKind.VISIT_SUPER_FIELD_FIELD_SET_IF_NULL,
- getter: 'field(B#a)', setter: 'field(A#a)',
- rhs: '42')),*/
+ // TODO(johnniwinther): Change this to
+ // [VISIT_SUPER_FIELD_FIELD_SET_IF_NULL] when dart2js supports shadow
+ // setters.
+ const Visit(VisitKind.VISIT_SUPER_FINAL_FIELD_SET_IF_NULL,
+ element: 'field(B#a)',
+ rhs: '42')),
const Test.clazz(
'''
class B {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698