Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2095873003: [mojo-edk] Process proxy disruptions locally. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Process proxy disruptions locally. When a proxy is closed due to node channel loss, the disruption is broadcast to all other nodes, except for the local node. If the port pointing to the proxy is local (i.e. with the primordial ChannelMojo pipe that hasn't yet fully collapsed), it won't receive the proxy closure event and detect the peer is closed. BUG=618206 Committed: https://crrev.com/8a8fa707e2aa5268dcf45ea1c5f996dbb2162366 Cr-Commit-Position: refs/heads/master@{#401869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M mojo/edk/system/ports/node.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/edk/system/ports/ports_unittest.cc View 4 chunks +77 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Anand Mistry (off Chromium)
The alternative is to include the local node in broadcast messages. I fear that might ...
4 years, 6 months ago (2016-06-24 09:37:23 UTC) #2
Ken Rockot(use gerrit already)
lgtm Aha. No this seems like the right solution to me. LGTM
4 years, 6 months ago (2016-06-24 15:13:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095873003/1
4 years, 6 months ago (2016-06-24 15:13:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 16:16:08 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 16:17:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a8fa707e2aa5268dcf45ea1c5f996dbb2162366
Cr-Commit-Position: refs/heads/master@{#401869}

Powered by Google App Engine
This is Rietveld 408576698