Build afl-tools with fuzzers.

Build afl-tools with fuzzers.

1. Build afl-fuzz, afl-cmin, afl-tmin and afl-showmap with fuzzers.
2. Add hash.h from afl-2.16b since afl-tools depend on hash.h and it
has a license header.
3. Fix inconsistencies in README.chromium

BUG=611337
Committed: https://crrev.com/7243ef31ec3985f24d8e63282d5c68b2ae618e2e
Cr-Commit-Position: refs/heads/master@{#402280}

[Jonathan Metzman, 2016-06-24 14:35:05]

Description was changed from

==========
Build afl-tools with fuzzers.

1. Build afl-fuzz, afl-cmin, afl-tmin and afl-showmap with fuzzers.
2. Add hash.h from afl-2.16b since afl-tools depend on hash.h and it
has a license header.
3. Fix inconsistencies in README.chromium

BUG=611337
==========

to

==========
Build afl-tools with fuzzers.

1. Build afl-fuzz, afl-cmin, afl-tmin and afl-showmap with fuzzers.
2. Add hash.h from afl-2.16b since afl-tools depend on hash.h and it
has a license header.
3. Fix inconsistencies in README.chromium

BUG=611337
==========

[Jonathan Metzman, 2016-06-24 14:35:06]

metzman@google.com changed reviewers:
+ inferno@chromium.org

[inferno, 2016-06-27 04:27:39]

lgtm with nits. After fixing nits, please add dpranke for owner review of
build.gn file.

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn
File third_party/afl/BUILD.gn (right):

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:40: copy("afl-cmin") {
copy blocks will look more readable after the config block (and near the
executable blocks).

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:55: # Copy the docs folder. This is so that we can use
a real value for for
s/for for/for

Why are docs even needed for compiling, can we skip it altogether.

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:66: "src/config.h",
alpha order

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:79: "-Wno-pointer-sign",
Move this near line 83 and remove its comment from line 76.

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:92: # Since we are not running make install, don't
Missing language in comment after "don't"

[Jonathan Metzman, 2016-06-27 04:33:42]

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn
File third_party/afl/BUILD.gn (right):

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:55: # Copy the docs folder. This is so that we can use
a real value for for
On 2016/06/27 04:27:39, inferno wrote:
> s/for for/for
> 
> Why are docs even needed for compiling, can we skip it altogether.

When afl-fuzz prints error messages it sometimes includes a path to docs.
The path is passed as a macro by make.
We could just give a fake path (or maybe some other message instead).

[inferno, 2016-06-27 04:49:10]

On 2016/06/27 04:33:42, Jonathan Metzman wrote:
> https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn
> File third_party/afl/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
> third_party/afl/BUILD.gn:55: # Copy the docs folder. This is so that we can
use
> a real value for for
> On 2016/06/27 04:27:39, inferno wrote:
> > s/for for/for
> > 
> > Why are docs even needed for compiling, can we skip it altogether.
> 
> When afl-fuzz prints error messages it sometimes includes a path to docs.
> The path is passed as a macro by make.
> We could just give a fake path (or maybe some other message instead).

That is fine then, please add in comments.

[Jonathan Metzman, 2016-06-27 05:36:07]

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn
File third_party/afl/BUILD.gn (right):

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:40: copy("afl-cmin") {
On 2016/06/27 04:27:39, inferno wrote:
> copy blocks will look more readable after the config block (and near the
> executable blocks).

Done.

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:66: "src/config.h",
On 2016/06/27 04:27:39, inferno wrote:
> alpha order

Done.

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:79: "-Wno-pointer-sign",
On 2016/06/27 04:27:39, inferno wrote:
> Move this near line 83 and remove its comment from line 76.

Done.

https://codereview.chromium.org/2095843002/diff/1/third_party/afl/BUILD.gn#ne...
third_party/afl/BUILD.gn:92: # Since we are not running make install, don't
On 2016/06/27 04:27:39, inferno wrote:
> Missing language in comment after "don't"

Done.

[Jonathan Metzman, 2016-06-27 05:37:03]

metzman@google.com changed reviewers:
+ dpranke@google.com

[Jonathan Metzman, 2016-06-27 05:37:03]

Dirk, can you do the owner review for this please?

[Dirk Pranke, 2016-06-27 16:26:54]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-06-27 16:26:55]

lgtm

https://codereview.chromium.org/2095843002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/2095843002/diff/20001/build/config/sanitizers...
build/config/sanitizers/BUILD.gn:31: deps += [ "//third_party/afl:afl" ]
nit: just "//third_party/afl".

[Jonathan Metzman, 2016-06-27 16:40:09]

https://codereview.chromium.org/2095843002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/2095843002/diff/20001/build/config/sanitizers...
build/config/sanitizers/BUILD.gn:31: deps += [ "//third_party/afl:afl" ]
On 2016/06/27 16:26:54, Dirk Pranke wrote:
> nit: just "//third_party/afl".

Done.

[Jonathan Metzman, 2016-06-27 16:40:09]

https://codereview.chromium.org/2095843002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/2095843002/diff/20001/build/config/sanitizers...
build/config/sanitizers/BUILD.gn:31: deps += [ "//third_party/afl:afl" ]
On 2016/06/27 16:26:54, Dirk Pranke wrote:
> nit: just "//third_party/afl".

Done.

[inferno, 2016-06-27 19:42:47]

The CQ bit was checked by inferno@chromium.org

[inferno, 2016-06-27 19:42:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
inferno@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2095843002/#ps40001
(title: "Change //third_party/afl:afl to //third_party/afl.")

[commit-bot: I haz the power, 2016-06-27 19:43:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 21:07:51]

Description was changed from

==========
Build afl-tools with fuzzers.

1. Build afl-fuzz, afl-cmin, afl-tmin and afl-showmap with fuzzers.
2. Add hash.h from afl-2.16b since afl-tools depend on hash.h and it
has a license header.
3. Fix inconsistencies in README.chromium

BUG=611337
==========

to

==========
Build afl-tools with fuzzers.

1. Build afl-fuzz, afl-cmin, afl-tmin and afl-showmap with fuzzers.
2. Add hash.h from afl-2.16b since afl-tools depend on hash.h and it
has a license header.
3. Fix inconsistencies in README.chromium

BUG=611337
==========

[commit-bot: I haz the power, 2016-06-27 21:07:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-27 21:09:37]

Description was changed from

==========
Build afl-tools with fuzzers.

1. Build afl-fuzz, afl-cmin, afl-tmin and afl-showmap with fuzzers.
2. Add hash.h from afl-2.16b since afl-tools depend on hash.h and it
has a license header.
3. Fix inconsistencies in README.chromium

BUG=611337
==========

to

==========
Build afl-tools with fuzzers.

1. Build afl-fuzz, afl-cmin, afl-tmin and afl-showmap with fuzzers.
2. Add hash.h from afl-2.16b since afl-tools depend on hash.h and it
has a license header.
3. Fix inconsistencies in README.chromium

BUG=611337

Committed: https://crrev.com/7243ef31ec3985f24d8e63282d5c68b2ae618e2e
Cr-Commit-Position: refs/heads/master@{#402280}
==========

[commit-bot: I haz the power, 2016-06-27 21:09:38]

Patchset 3 (id:??) landed as
https://crrev.com/7243ef31ec3985f24d8e63282d5c68b2ae618e2e
Cr-Commit-Position: refs/heads/master@{#402280}