Make DCHECKs into CHECKs for CT policy code

Make DCHECKs into CHECKs for CT policy code

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
R=eroman@chromium.org

Committed: https://crrev.com/be81cd6044e1bc5d846cb52712fc2ee15779a85a
Cr-Commit-Position: refs/heads/master@{#401775}

[Ryan Sleevi, 2016-06-23 23:47:00]

Description was changed from

==========
Make the DCHECKs into CHECKs

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
==========

to

==========
Make DCHECKs into CHECKs for CT policy code

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
==========

[Ryan Sleevi, 2016-06-23 23:47:08]

rsleevi@chromium.org changed reviewers:
+ eroman@chromium.org

[Ryan Sleevi, 2016-06-23 23:47:12]

The CQ bit was checked by rsleevi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 23:48:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2095823002/1

[eroman, 2016-06-23 23:49:31]

lgtm

[Ryan Sleevi, 2016-06-24 01:03:25]

Description was changed from

==========
Make DCHECKs into CHECKs for CT policy code

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
==========

to

==========
Make DCHECKs into CHECKs for CT policy code

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
R=eroman@chromium.org
==========

[commit-bot: I haz the power, 2016-06-24 01:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 01:24:38]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2016-06-24 01:31:05]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2016-06-24 01:32:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2095823002/1

[commit-bot: I haz the power, 2016-06-24 01:39:11]

Description was changed from

==========
Make DCHECKs into CHECKs for CT policy code

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
R=eroman@chromium.org
==========

to

==========
Make DCHECKs into CHECKs for CT policy code

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
R=eroman@chromium.org
==========

[commit-bot: I haz the power, 2016-06-24 01:39:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-24 01:40:37]

Description was changed from

==========
Make DCHECKs into CHECKs for CT policy code

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
R=eroman@chromium.org
==========

to

==========
Make DCHECKs into CHECKs for CT policy code

Unfortunately, there's some code in the tree making SSL and QUIC
sockets without any test coverage, and supplying NULL objects.
Make the DCHECKs into CHECKs, so that they can be quickly
isolated, as otherwise the crash does not trigger until the socket
is in the asynchronous cert verification mode, which does not
have enough context to narrow down which caller created the socket.

BUG=622098
R=eroman@chromium.org

Committed: https://crrev.com/be81cd6044e1bc5d846cb52712fc2ee15779a85a
Cr-Commit-Position: refs/heads/master@{#401775}
==========

[commit-bot: I haz the power, 2016-06-24 01:40:38]

Patchset 1 (id:??) landed as
https://crrev.com/be81cd6044e1bc5d846cb52712fc2ee15779a85a
Cr-Commit-Position: refs/heads/master@{#401775}