Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2095813002: Revert of Routing IME Result Calls to the Correct RenderWidgetHost (Aura Only) (Closed)

Created:
4 years, 6 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
kenrb, EhsanK, Charlie Reis
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, nona+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, site-isolation-reviews_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Routing IME Result Calls to the Correct RenderWidgetHost (Aura Only) (patchset #8 id:140001 of https://codereview.chromium.org/2045363002/ ) Reason for revert: This patch added unit tests that leave behind state that will break other tests if content_unittests is run with --single-process-tests (as it is on the Dr. Memory bots). Original issue's description: > Routing IME Result Calls to the Correct RenderWidgetHost (Aura Only) > > Currently, the IME result calls on ui::TextInputClient (RenderWidgetHostViewAura) are only > routed to the RenderWidgetHostImpl corresponding to the tab's RenderWidgetHostView. Therefore, > the IME related IPC arrive at the main frame's RenderWidget only. In the OOPIF structure, > the IME result might be intended to a child frame's RenderWidget. > > This patch will route all such IME calls to the RenderWidgetHost which currently has the > active text input state. > > The patch also adds four unit tests to RenderWidgetHostViewAuraTests to verify that the > routing is done properly. > > BUG=578168 > > Committed: https://crrev.com/d33fd7859cac797067a2b8a8e55f6dbac59bee19 > Cr-Commit-Position: refs/heads/master@{#401465} TBR=kenrb@chromium.org,creis@chromium.org,ekaramad@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=578168, 622793 Committed: https://crrev.com/7225ddf9fd7c32a1de91a9f2c8b755d736b2fd0d Cr-Commit-Position: refs/heads/master@{#401771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -261 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 8 chunks +0 lines, -220 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.h View 4 chunks +5 lines, -17 lines 0 comments Download
M content/browser/renderer_host/text_input_manager.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/public/test/text_input_test_utils.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Reilly Grant (use Gerrit)
Created Revert of Routing IME Result Calls to the Correct RenderWidgetHost (Aura Only)
4 years, 6 months ago (2016-06-23 23:43:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095813002/1
4 years, 6 months ago (2016-06-23 23:43:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 01:25:13 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 01:28:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7225ddf9fd7c32a1de91a9f2c8b755d736b2fd0d
Cr-Commit-Position: refs/heads/master@{#401771}

Powered by Google App Engine
This is Rietveld 408576698