Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2095793002: Convert determining restore bounds to use ash/common type (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert determining restore bounds to use ash/common type This change converts from using views::Widget to determine restore bounds to using WindowState and WmWindow. This way the code can be ported to use work in mash. BUG=612629 TEST=covered by tests R=skuhne@chromium.org Committed: https://crrev.com/b132099e1c9edf0dc8038098aae6ba4da677622c Cr-Commit-Position: refs/heads/master@{#401877}

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M ash/aura/wm_window_aura.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 2 chunks +29 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 6 months ago (2016-06-23 23:36:37 UTC) #1
Mr4D (OOO till 08-26)
lgtm
4 years, 6 months ago (2016-06-24 05:40:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095793002/20001
4 years, 6 months ago (2016-06-24 15:40:55 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-24 16:31:11 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 16:37:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b132099e1c9edf0dc8038098aae6ba4da677622c
Cr-Commit-Position: refs/heads/master@{#401877}

Powered by Google App Engine
This is Rietveld 408576698