Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2095773002: Fix the milo-bootstrap theme css (Closed)

Created:
4 years, 6 months ago by Ryan Tseng
Modified:
4 years, 5 months ago
Reviewers:
nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Fix the milo-bootstrap theme css Someone moved the bootstrap files again which caused the bootstrap theme to break. Checking two css files and one js file directly into the milo repository to avoid this. BUG=620911 Committed: https://github.com/luci/luci-go/commit/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b

Patch Set 1 #

Patch Set 2 : Retrain #

Patch Set 3 : Move under third_party #

Patch Set 4 : Retrain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -33 lines) Patch
M appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuilder-Basic_Test_no_builds.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuilder-Basic_Test_with_builds.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/bootstrap-frontend.testableFrontpage-Basic_frontpage.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/bootstrap-settings.TestableSettings-Settings.html View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/bootstrap-swarming.TestableBuild-Basic_successful_build.html View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/bootstrap-swarming.TestableLog-Basic_log.html View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + appengine/cmd/milo/frontend/static/bootstrap/third_party/css/bootstrap-theme.min.css View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/cmd/milo/frontend/static/bootstrap/third_party/css/bootstrap.min.css View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/cmd/milo/frontend/static/bootstrap/third_party/js/bootstrap.min.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A appengine/cmd/milo/frontend/static/common/third_party/js/jquery.min.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M appengine/cmd/milo/frontend/templates/bootstrap/includes/bootstrap.html View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 30 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095773002/1
4 years, 6 months ago (2016-06-23 21:41:22 UTC) #2
hinoka
I'm tired of milo breaking whenever someone decides to move the "common" folders. This is ...
4 years, 6 months ago (2016-06-23 21:43:23 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095773002/20001
4 years, 6 months ago (2016-06-23 21:43:52 UTC) #8
Ryan Tseng
Retrain
4 years, 6 months ago (2016-06-23 21:43:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Luci-go Presubmit (Swarming) on master.tryserver.infra (JOB_FAILED, https://luci-milo.appspot.com/swarming/prod/2f9809d693c59d10)
4 years, 6 months ago (2016-06-23 21:49:07 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095773002/40001
4 years, 6 months ago (2016-06-23 21:54:46 UTC) #13
Ryan Tseng
Move under third_party
4 years, 6 months ago (2016-06-23 21:54:47 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 22:19:01 UTC) #16
nodir
lgtm
4 years, 5 months ago (2016-06-28 22:51:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095773002/40001
4 years, 5 months ago (2016-06-30 21:43:44 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Trusty%2064%20Tester/builds/1310) ...
4 years, 5 months ago (2016-06-30 21:48:37 UTC) #21
Ryan Tseng
Retrain
4 years, 5 months ago (2016-07-15 20:48:13 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095773002/60001
4 years, 5 months ago (2016-07-15 20:52:15 UTC) #28
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 20:55:14 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/b98cf83f2b7e526dfd65c97037f06e5348b1ac2b

Powered by Google App Engine
This is Rietveld 408576698