Improve hint table validation checks.

Improve hint table validation checks.

Check required hint table dictionary entries and make sure they:
- Exist.
- Are of the right type.

Along the way:
- Fix FX_atonum() to not have a non-const pass-by-ref param.
- Simplify code in CPDF_StreamContentParser.
- Make CPDF_Number::IsInteger() a const method.

BUG=610555
Committed: https://pdfium.googlesource.com/pdfium/+/29d447ae35101675a2a2d8bc1dcfca65de7f3929

[Lei Zhang, 2016-06-23 22:29:18]

Description was changed from

==========
Beef up hint table validation checks.

Along the way:
- Fix FX_atonum() to not have a non-const pass-by-ref param.
- Simplify code in CPDF_StreamContentParser.
- Make CPDF_Number::IsInteger() a const method.

BUG=610555
==========

to

==========
Improve hint table validation checks.

Check required hint table dictionary entries and make sure they:
- Exist.
- Are of the right type.

Along the way:
- Fix FX_atonum() to not have a non-const pass-by-ref param.
- Simplify code in CPDF_StreamContentParser.
- Make CPDF_Number::IsInteger() a const method.

BUG=610555
==========

[Lei Zhang, 2016-06-23 22:29:18]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-06-23 23:35:26]

https://codereview.chromium.org/2095763003/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right):

https://codereview.chromium.org/2095763003/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:749: if (nHintStreamSize != 2 &&
nHintStreamSize != 4) {
Where does the 4 come from?

[Lei Zhang, 2016-06-24 00:37:43]

https://codereview.chromium.org/2095763003/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right):

https://codereview.chromium.org/2095763003/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:749: if (nHintStreamSize != 2 &&
nHintStreamSize != 4) {
On 2016/06/23 23:35:25, dsinclair wrote:
> Where does the 4 come from?

PDF 1.7 spec, page 1029, Table F.1.

[dsinclair, 2016-06-24 02:57:19]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-24 02:57:19]

lgtm

[commit-bot: I haz the power, 2016-06-24 02:57:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2095763003/1

[commit-bot: I haz the power, 2016-06-24 02:57:49]

Description was changed from

==========
Improve hint table validation checks.

Check required hint table dictionary entries and make sure they:
- Exist.
- Are of the right type.

Along the way:
- Fix FX_atonum() to not have a non-const pass-by-ref param.
- Simplify code in CPDF_StreamContentParser.
- Make CPDF_Number::IsInteger() a const method.

BUG=610555
==========

to

==========
Improve hint table validation checks.

Check required hint table dictionary entries and make sure they:
- Exist.
- Are of the right type.

Along the way:
- Fix FX_atonum() to not have a non-const pass-by-ref param.
- Simplify code in CPDF_StreamContentParser.
- Make CPDF_Number::IsInteger() a const method.

BUG=610555

Committed:
https://pdfium.googlesource.com/pdfium/+/29d447ae35101675a2a2d8bc1dcfca65de7f...
==========

[commit-bot: I haz the power, 2016-06-24 02:57:50]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/29d447ae35101675a2a2d8bc1dcfca65de7f...