src/IceTargetLoweringX86BaseImpl.h - Issue 2095763002: Instrumented local variables and implemented runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 2095763002: Instrumented local variables and implemented runtime. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fixed alloca ordering and added the alignment test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX86BaseImpl.h

diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h

index 49c929b8a5983393e4ddf02cc910c100cb5c6951..c5f6783bfadf8747185630f8c6d1ffd5c8ed2eab 100644

--- a/src/IceTargetLoweringX86BaseImpl.h

+++ b/src/IceTargetLoweringX86BaseImpl.h

@@ -5331,7 +5331,7 @@ const Inst *AddressOptimizer::matchOffsetIndexOrBase(

NewOffset += MoreOffset;

}

if (Utils::WouldOverflowAdd(*Offset, NewOffset << Shift))

- return nullptr;

+ return nullptr;

*IndexOrBase = NewIndexOrBase;

*Offset += (NewOffset << Shift);

// Shift is always zero if this is called with the base

« src/IceCfg.cpp ('K') | « src/IceInstrumentation.cpp ('k') | tests_lit/asan_tests/alignment.ll » ('j') | no next file with comments »