Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2095673003: Enable hermetic build for Google Chrome Mac official. (Closed)

Created:
4 years, 6 months ago by justincohen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enable hermetic build for Google Chrome Mac official. BUG=623155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json View 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
erikchen
thakis: Please review.
4 years, 6 months ago (2016-06-24 18:07:04 UTC) #2
Nico
no tracking bug? what's the rollout plan for this? if this works, turn this on ...
4 years, 6 months ago (2016-06-24 19:34:28 UTC) #3
erikchen
On 2016/06/24 19:34:28, Nico wrote: > no tracking bug? > > what's the rollout plan ...
4 years, 6 months ago (2016-06-24 19:56:56 UTC) #5
Nico
If it already works on some builds, why not turn it on everywhere? But lgtm ...
4 years, 6 months ago (2016-06-24 20:17:11 UTC) #6
erikchen
On 2016/06/24 20:17:11, Nico wrote: > If it already works on some builds, why not ...
4 years, 6 months ago (2016-06-24 20:18:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095673003/1
4 years, 6 months ago (2016-06-24 20:19:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5709)
4 years, 6 months ago (2016-06-24 20:25:56 UTC) #11
erikchen
sergeyberezin: Please review.
4 years, 5 months ago (2016-06-27 14:40:43 UTC) #13
Sergey Berezin
rs lgtm
4 years, 5 months ago (2016-06-27 19:21:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095673003/1
4 years, 5 months ago (2016-06-27 19:25:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5752)
4 years, 5 months ago (2016-06-27 19:32:40 UTC) #18
erikchen
4 years, 5 months ago (2016-06-27 22:21:22 UTC) #19
On 2016/06/27 19:32:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Build Presubmit on master.tryserver.infra (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

I've landed https://codereview.chromium.org/2102783002/, so this CL can be
closed.

Powered by Google App Engine
This is Rietveld 408576698