Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2095673002: Share SharedFunctionInfo between all functions created for a FunctionTemplateInfo (Closed)

Created:
4 years, 6 months ago by Toon Verwaest
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Share SharedFunctionInfo between all functions created for a FunctionTemplateInfo BUG= Committed: https://crrev.com/a7a9ac37d4639555ffd28e97988c1228ed2a6fff Cr-Commit-Position: refs/heads/master@{#37252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -107 lines) Patch
M src/api-natives.cc View 2 chunks +60 lines, -79 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/factory.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/factory.cc View 3 chunks +3 lines, -16 lines 0 comments Download
M src/objects.h View 4 chunks +8 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/objects-inl.h View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095673002/1
4 years, 6 months ago (2016-06-23 15:51:21 UTC) #2
Toon Verwaest
ptal
4 years, 6 months ago (2016-06-23 16:11:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 16:19:09 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-24 13:32:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095673002/1
4 years, 6 months ago (2016-06-24 13:49:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 13:51:34 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 13:53:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7a9ac37d4639555ffd28e97988c1228ed2a6fff
Cr-Commit-Position: refs/heads/master@{#37252}

Powered by Google App Engine
This is Rietveld 408576698