Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2095663003: improve unicode support (Closed)

Created:
4 years, 6 months ago by martiniss
Modified:
4 years, 6 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

improve unicode support * Allow unicode in log lines * Allow simulation tests to unicode

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M recipe_engine/step_runner.py View 4 chunks +4 lines, -4 lines 1 comment Download
M recipe_engine/stream.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_engine/third_party/expect_tests/serialize.py View 1 chunk +2 lines, -2 lines 1 comment Download
A recipes/engine_tests/unicode.py View 1 chunk +19 lines, -0 lines 1 comment Download
A recipes/engine_tests/unicode.expected/basic.json View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095663003/1
4 years, 6 months ago (2016-06-23 17:50:46 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/300)
4 years, 6 months ago (2016-06-23 17:54:16 UTC) #4
tandrii(chromium)
https://codereview.chromium.org/2095663003/diff/1/recipe_engine/step_runner.py File recipe_engine/step_runner.py (right): https://codereview.chromium.org/2095663003/diff/1/recipe_engine/step_runner.py#newcode48 recipe_engine/step_runner.py:48: self.extra = StringIO.StringIO() why is this change required? https://codereview.chromium.org/2095663003/diff/1/recipe_engine/third_party/expect_tests/serialize.py ...
4 years, 6 months ago (2016-06-23 19:52:36 UTC) #6
martiniss
4 years, 6 months ago (2016-06-23 20:25:20 UTC) #7 
Sorry, ignore this CL. Other CL has more review comments:
https://codereview.chromium.org/2088343002

Powered by Google App Engine
This is Rietveld 408576698