xfa/fxfa/app/xfa_ffwidgethandler.cpp - Issue 2095653002: Remove NULL in xfa/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_ffwidgethandler.cpp

Issue 2095653002: Remove NULL in xfa/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase to master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: xfa/fxfa/app/xfa_ffwidgethandler.cpp

diff --git a/xfa/fxfa/app/xfa_ffwidgethandler.cpp b/xfa/fxfa/app/xfa_ffwidgethandler.cpp

index 5221c7cd6dd5839505dbdcb34eb6a91dee966e31..aaaf07ad6693ebc911adca1bb41b92014ce08d06 100644

--- a/xfa/fxfa/app/xfa_ffwidgethandler.cpp

+++ b/xfa/fxfa/app/xfa_ffwidgethandler.cpp

@@ -481,7 +481,7 @@ CXFA_Node* CXFA_FFWidgetHandler::CreateSubform(CXFA_Node* pParent,

CXFA_Node* CXFA_FFWidgetHandler::CreateFormItem(XFA_Element eElement,

CXFA_Node* pParent,

CXFA_Node* pBefore) const {

- CXFA_Node* pTemplateParent = pParent ? pParent->GetTemplateNode() : NULL;

+ CXFA_Node* pTemplateParent = pParent ? pParent->GetTemplateNode() : nullptr;

CXFA_Node* pNewFormItem = pTemplateParent->CloneTemplateToForm(FALSE);

if (pParent)

pParent->InsertChild(pNewFormItem, pBefore);

@@ -491,10 +491,10 @@ CXFA_Node* CXFA_FFWidgetHandler::CreateFormItem(XFA_Element eElement,

CXFA_Node* CXFA_FFWidgetHandler::CreateCopyNode(XFA_Element eElement,

CXFA_Node* pParent,

CXFA_Node* pBefore) const {

- CXFA_Node* pTemplateParent = pParent ? pParent->GetTemplateNode() : NULL;

+ CXFA_Node* pTemplateParent = pParent ? pParent->GetTemplateNode() : nullptr;

CXFA_Node* pNewNode =

CreateTemplateNode(eElement, pTemplateParent,

- pBefore ? pBefore->GetTemplateNode() : NULL)

+ pBefore ? pBefore->GetTemplateNode() : nullptr)

->Clone(FALSE);

if (pParent)

pParent->InsertChild(pNewNode, pBefore);