Remove NULL in xfa/

xfa/fgas/crt/fgas_utils.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FGAS_CRT_FGAS_UTILS_H_
 #define XFA_FGAS_CRT_FGAS_UTILS_H_
 
 #include "core/fxcrt/include/fx_coordinates.h"
@@ skipping 360 matching lines @@
   void* m_pData;
 };
 
 template <class baseType>
 class CFX_DiscreteArrayTemplate : public CFX_BaseDiscreteArray {
  public:
   CFX_DiscreteArrayTemplate(int32_t iChunkSize = 100)
       : CFX_BaseDiscreteArray(iChunkSize, sizeof(baseType)) {}
   baseType& GetAt(int32_t index, const baseType& defValue) const {
     baseType* p = (baseType*)CFX_BaseDiscreteArray::GetAt(index);
-    return p == NULL ? (baseType&)defValue : *p;
+    return !p ? (baseType&)defValue : *p;

[Lei Zhang, 2016/06/23 17:56:00]

flip

[dsinclair, 2016/06/23 18:46:52]

Done.

   }
   baseType* GetPtrAt(int32_t index) const {
     return (baseType*)CFX_BaseDiscreteArray::GetAt(index);
   }
   void SetAtGrow(int32_t index, const baseType& element) {
     *(baseType*)CFX_BaseDiscreteArray::AddSpaceTo(index) = element;
   }
   void RemoveAll() { CFX_BaseDiscreteArray::RemoveAll(); }
 };
 typedef CFX_DiscreteArrayTemplate<void*> CFX_PtrDiscreteArray;
@@ skipping 48 matching lines @@
       : CFX_BaseStack(iChunkSize, sizeof(baseType)) {}
   ~CFX_ObjectStackTemplate() { RemoveAll(); }
   int32_t Push(const baseType& element) {
     int32_t index = CFX_BaseStack::GetSize();
     baseType* p = (baseType*)CFX_BaseStack::Push();
     new ((void*)p) baseType(element);
     return index;
   }
   void Pop() {
     baseType* p = (baseType*)CFX_BaseStack::GetTopElement();
-    if (p != NULL) {
+    if (p) {
       p->~baseType();
     }
     CFX_BaseStack::Pop();
   }
   baseType* GetTopElement() const {
     return (baseType*)CFX_BaseStack::GetTopElement();
   }
   int32_t GetSize() const { return CFX_BaseStack::GetSize(); }
   baseType* GetAt(int32_t index) const {
     return (baseType*)CFX_BaseStack::GetAt(index);
@@ skipping 22 matching lines @@
     }
     RemoveAll(TRUE);
     for (int32_t i = iStart; i < iEnd; i++) {
       Push(*src.GetAt(i));
     }
     return CFX_BaseStack::GetSize();
   }
 };
 
 #endif  // XFA_FGAS_CRT_FGAS_UTILS_H_