Remove NULL in xfa/

xfa/fxfa/parser/cxfa_widgetdata.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/parser/cxfa_widgetdata.h"
 
 #include "core/fxcrt/include/fx_ext.h"
 #include "xfa/fxbarcode/include/BC_Library.h"
@@ skipping 58 matching lines @@
   }
   return TRUE;
 }
 
 }  // namespace
 
 CXFA_WidgetData::CXFA_WidgetData(CXFA_Node* pNode)
     : CXFA_Data(pNode),
       m_bIsNull(TRUE),
       m_bPreNull(TRUE),
-      m_pUiChildNode(NULL),
+      m_pUiChildNode(nullptr),
       m_eUIType(XFA_Element::Unknown) {}
 
 CXFA_Node* CXFA_WidgetData::GetUIChild() {
   if (m_eUIType == XFA_Element::Unknown)
     m_pUiChildNode = XFA_CreateUIChild(m_pNode, m_eUIType);
 
   return m_pUiChildNode;
 }
 
 XFA_Element CXFA_WidgetData::GetUIType() {
@@ skipping 344 matching lines @@
       }
       pText = pText->GetNodeItem(XFA_NODEITEM_NextSibling);
     }
     SyncValue(wsContent, bNotify);
   }
 }
 
 CXFA_Node* CXFA_WidgetData::GetExclGroupNode() {
   CXFA_Node* pExcl = ToNode(m_pNode->GetNodeItem(XFA_NODEITEM_Parent));
   if (!pExcl || pExcl->GetElementType() != XFA_Element::ExclGroup)
-    return NULL;
+    return nullptr;
   return pExcl;
 }
 
 CXFA_Node* CXFA_WidgetData::GetSelectedMember() {
-  CXFA_Node* pSelectedMember = NULL;
+  CXFA_Node* pSelectedMember = nullptr;
   CFX_WideString wsState = GetRawValue();
   if (wsState.IsEmpty())
     return pSelectedMember;
 
   for (CXFA_Node* pNode = ToNode(m_pNode->GetNodeItem(XFA_NODEITEM_FirstChild));
        pNode; pNode = pNode->GetNodeItem(XFA_NODEITEM_NextSibling)) {
     CXFA_WidgetData widgetData(pNode);
     if (widgetData.GetCheckState() == XFA_CHECKSTATE_On) {
       pSelectedMember = pNode;
       break;
@@ skipping 49 matching lines @@
   }
   if (m_pNode) {
     m_pNode->SetContent(wsExclGroup, wsExclGroup, bNotify, bScriptModify,
                         bSyncData);
   }
 }
 
 CXFA_Node* CXFA_WidgetData::GetExclGroupFirstMember() {
   CXFA_Node* pExcl = GetNode();
   if (!pExcl)
-    return NULL;
+    return nullptr;
 
   CXFA_Node* pNode = pExcl->GetNodeItem(XFA_NODEITEM_FirstChild);
   while (pNode) {
     if (pNode->GetElementType() == XFA_Element::Field)
       return pNode;
 
     pNode = pNode->GetNodeItem(XFA_NODEITEM_NextSibling);
   }
-  return NULL;
+  return nullptr;
 }
 CXFA_Node* CXFA_WidgetData::GetExclGroupNextMember(CXFA_Node* pNode) {
   if (!pNode)
-    return NULL;
+    return nullptr;
 
   CXFA_Node* pNodeField = pNode->GetNodeItem(XFA_NODEITEM_NextSibling);
   while (pNodeField) {
     if (pNodeField->GetElementType() == XFA_Element::Field)
       return pNodeField;
 
     pNodeField = pNodeField->GetNodeItem(XFA_NODEITEM_NextSibling);
   }
-  return NULL;
+  return nullptr;
 }
 
 int32_t CXFA_WidgetData::GetChoiceListCommitOn() {
   CXFA_Node* pUIChild = GetUIChild();
   if (pUIChild)
     return pUIChild->GetEnum(XFA_ATTRIBUTE_CommitOn);
   return XFA_GetAttributeDefaultValue_Enum(
       XFA_Element::ChoiceList, XFA_ATTRIBUTE_CommitOn, XFA_XDPPACKET_Form);
 }
 
@@ skipping 14 matching lines @@
 }
 
 FX_BOOL CXFA_WidgetData::IsListBox() {
   int32_t iOpenMode = GetChoiceListOpen();
   return (iOpenMode == XFA_ATTRIBUTEENUM_Always ||
           iOpenMode == XFA_ATTRIBUTEENUM_MultiSelect);
 }
 
 int32_t CXFA_WidgetData::CountChoiceListItems(FX_BOOL bSaveValue) {
   CXFA_NodeArray pItems;
-  CXFA_Node* pItem = NULL;
+  CXFA_Node* pItem = nullptr;
   int32_t iCount = 0;
   CXFA_Node* pNode = m_pNode->GetNodeItem(XFA_NODEITEM_FirstChild);
   for (; pNode; pNode = pNode->GetNodeItem(XFA_NODEITEM_NextSibling)) {
     if (pNode->GetElementType() != XFA_Element::Items)
       continue;
 
     iCount++;
     pItems.Add(pNode);
     if (iCount == 2)
       break;
@@ skipping 45 matching lines @@
       pItem->TryContent(wsText);
       return TRUE;
     }
   }
   return FALSE;
 }
 
 void CXFA_WidgetData::GetChoiceListItems(CFX_WideStringArray& wsTextArray,
                                          FX_BOOL bSaveValue) {
   CXFA_NodeArray pItems;
-  CXFA_Node* pItem = NULL;
+  CXFA_Node* pItem = nullptr;
   int32_t iCount = 0;
   CXFA_Node* pNode = m_pNode->GetNodeItem(XFA_NODEITEM_FirstChild);
   for (; pNode; pNode = pNode->GetNodeItem(XFA_NODEITEM_NextSibling)) {
     if (pNode->GetElementType() != XFA_Element::Items)
       continue;
 
     iCount++;
     pItems.Add(pNode);
     if (iCount == 2)
       break;
@@ skipping 283 matching lines @@
       continue;
 
     iCount++;
     listitems.Add(pItems);
   }
   if (iCount <= 1) {
     wsLabel = wsValue;
   } else {
     CXFA_Node* pLabelItems = listitems[0];
     FX_BOOL bSave = pLabelItems->GetBoolean(XFA_ATTRIBUTE_Save);
-    CXFA_Node* pSaveItems = NULL;
+    CXFA_Node* pSaveItems = nullptr;
     if (bSave) {
       pSaveItems = pLabelItems;
       pLabelItems = listitems[1];
     } else {
       pSaveItems = listitems[1];
     }
     iCount = 0;
     int32_t iSearch = -1;
     CFX_WideString wsContent;
     CXFA_Node* pChildItem = pSaveItems->GetNodeItem(XFA_NODEITEM_FirstChild);
@@ skipping 25 matching lines @@
       continue;
 
     iCount++;
     listitems.Add(pItems);
   }
   if (iCount <= 1) {
     wsValue = wsLabel;
   } else {
     CXFA_Node* pLabelItems = listitems[0];
     FX_BOOL bSave = pLabelItems->GetBoolean(XFA_ATTRIBUTE_Save);
-    CXFA_Node* pSaveItems = NULL;
+    CXFA_Node* pSaveItems = nullptr;
     if (bSave) {
       pSaveItems = pLabelItems;
       pLabelItems = listitems[1];
     } else {
       pSaveItems = listitems[1];
     }
     iCount = 0;
     int32_t iSearch = -1;
     CFX_WideString wsContent;
     CXFA_Node* pChildItem = pLabelItems->GetNodeItem(XFA_NODEITEM_FirstChild);
@@ skipping 452 matching lines @@
       }
       break;
     }
     default:
       break;
   }
   return FALSE;
 }
 
 IFX_Locale* CXFA_WidgetData::GetLocal() {
-  IFX_Locale* pLocale = NULL;
   if (!m_pNode)
-    return pLocale;
+    return nullptr;
 
-  FX_BOOL bLocale = FALSE;
   CFX_WideString wsLocaleName;
-  bLocale = m_pNode->GetLocaleName(wsLocaleName);
-  if (bLocale) {
-    if (wsLocaleName == FX_WSTRC(L"ambient")) {
-      pLocale = m_pNode->GetDocument()->GetLocalMgr()->GetDefLocale();
-    } else {
-      pLocale =
-          m_pNode->GetDocument()->GetLocalMgr()->GetLocaleByName(wsLocaleName);
-    }
-  }
-  return pLocale;
+  if (!m_pNode->GetLocaleName(wsLocaleName))
+    return nullptr;
+  if (wsLocaleName == FX_WSTRC(L"ambient"))
+    return m_pNode->GetDocument()->GetLocalMgr()->GetDefLocale();
+  return m_pNode->GetDocument()->GetLocalMgr()->GetLocaleByName(wsLocaleName);
 }
 
 FX_BOOL CXFA_WidgetData::GetValue(CFX_WideString& wsValue,
                                   XFA_VALUEPICTURE eValueType) {
   wsValue = m_pNode->GetContent();
 
   if (eValueType == XFA_VALUEPICTURE_Display)
     GetItemLabel(wsValue.AsStringC(), wsValue);
 
   CFX_WideString wsPicture;
@@ skipping 286 matching lines @@
         }
       }
     } else if (wc == L'.') {
       iTread_ = 0;
       iLead = -1;
     }
     wsRet += wc;
   }
   return wsRet;
 }