Subzero: Make -asm-verbose local var offsets local.

Subzero: Make -asm-verbose local var offsets local.

When running with -asm-verbose, assembler directives like the following are generated:

  lv$__123 = 16

These symbols show up in "nm" output of the .o file, and cause inconsistencies in symbol numbering between filetype=asm and filetype=obj, when doing szbuild.py bisection debugging.

The fix is to prepend ".L" to the symbol name, so that the assembler treats it as local.  E.g.:

  .L$lv$__123 = 16

BUG= none
R=eholk@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=00b9edbac74fe06c78af4843606d52e30964fa06

[Jim Stichnoth, 2016-06-23 14:58:17]

Description was changed from

==========
Subzero: Make -asm-verbose local var offsets local.

BUG= none
==========

to

==========
Subzero: Make -asm-verbose local var offsets local.

When running with -asm-verbose, assembler directives like the following are
generated:

  lv$__123 = 16

These symbols show up in "nm" output of the .o file, and cause inconsistencies
in symbol numbering between filetype=asm and filetype=obj, when doing szbuild.py
bisection debugging.

The fix is to prepend ".L" to the symbol name, so that the assembler treats it
as local.

BUG= none
==========

[Jim Stichnoth, 2016-06-23 14:58:17]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, manasijm@google.com

[Jim Stichnoth, 2016-06-23 14:58:54]

Description was changed from

==========
Subzero: Make -asm-verbose local var offsets local.

When running with -asm-verbose, assembler directives like the following are
generated:

  lv$__123 = 16

These symbols show up in "nm" output of the .o file, and cause inconsistencies
in symbol numbering between filetype=asm and filetype=obj, when doing szbuild.py
bisection debugging.

The fix is to prepend ".L" to the symbol name, so that the assembler treats it
as local.

BUG= none
==========

to

==========
Subzero: Make -asm-verbose local var offsets local.

When running with -asm-verbose, assembler directives like the following are
generated:

  lv$__123 = 16

These symbols show up in "nm" output of the .o file, and cause inconsistencies
in symbol numbering between filetype=asm and filetype=obj, when doing szbuild.py
bisection debugging.

The fix is to prepend ".L" to the symbol name, so that the assembler treats it
as local.  E.g.:

  .L$lv$__123 = 16

BUG= none
==========

[Eric Holk, 2016-06-23 15:42:32]

lgtm

[Jim Stichnoth, 2016-06-25 17:14:43]

Description was changed from

==========
Subzero: Make -asm-verbose local var offsets local.

When running with -asm-verbose, assembler directives like the following are
generated:

  lv$__123 = 16

These symbols show up in "nm" output of the .o file, and cause inconsistencies
in symbol numbering between filetype=asm and filetype=obj, when doing szbuild.py
bisection debugging.

The fix is to prepend ".L" to the symbol name, so that the assembler treats it
as local.  E.g.:

  .L$lv$__123 = 16

BUG= none
==========

to

==========
Subzero: Make -asm-verbose local var offsets local.

When running with -asm-verbose, assembler directives like the following are
generated:

  lv$__123 = 16

These symbols show up in "nm" output of the .o file, and cause inconsistencies
in symbol numbering between filetype=asm and filetype=obj, when doing szbuild.py
bisection debugging.

The fix is to prepend ".L" to the symbol name, so that the assembler treats it
as local.  E.g.:

  .L$lv$__123 = 16

BUG= none
R=eholk@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-06-25 17:14:44]

Committed patchset #1 (id:1) manually as
00b9edbac74fe06c78af4843606d52e30964fa06 (presubmit successful).