Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2095623003: Reland: Extract media/capture/capture_unittests from media_unittests (Closed)

Created:
4 years, 6 months ago by mcasas
Modified:
4 years, 6 months ago
Reviewers:
miu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Extract media/capture/capture_unittests from media_unittests Original CL got reverted due to audio_unittests not finding two symbols error LNK2019: unresolved external symbol CLSID_DxDiagProvider error LNK2019: unresolved external symbol IID_IDxDiagProvider CQ doesn't have any gyp + win x64 bot, so didn't catch it, but it can be repro using win_clang_x64_rel bot -- see it failing in PS1 and compiling in PS2. Original's issue description ------------------------------------------- Extract media/capture/capture_unittests from media_unittests This CL: - extracts capture_unittests out of media_unittests. - adds it to all testing/buildbot/*.json where appropriate, i.e. where there is media_unittests. - adds the necessary .isolate and _apk.isolate. BUG=618718 TEST= No new code added, all bots running capture_unittests and being happy with it.¯ ------------------------------------------------------------------------ TBR=miu@chromium.org, xhwang@chromium.org, maruel@chromium.org, brettw@chromium.org Committed: https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e Cr-Commit-Position: refs/heads/master@{#401927}

Patch Set 1 : Verbatim https://codereview.chromium.org/2087683002/ #

Patch Set 2 : Added missing library dep #

Patch Set 3 : Rebase (testing/buildbot/chromium.fyi.json) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+577 lines, -34 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/all.gyp View 1 2 11 chunks +11 lines, -0 lines 0 comments Download
M media/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/run_all_unittests.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/capture/BUILD.gn View 2 chunks +9 lines, -4 lines 0 comments Download
M media/capture/capture.gyp View 3 chunks +87 lines, -8 lines 0 comments Download
A + media/capture/capture_unittests.isolate View 4 chunks +5 lines, -5 lines 0 comments Download
A + media/capture/capture_unittests_apk.isolate View 1 chunk +3 lines, -3 lines 0 comments Download
M media/capture/video/android/photo_capabilities.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/media.gyp View 1 4 chunks +11 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.android.json View 1 2 10 chunks +50 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 39 chunks +223 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 6 chunks +41 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 8 chunks +29 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webrtc.json View 3 chunks +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webrtc.fyi.json View 7 chunks +7 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
miu
diff between PS2 and PS1 lgtm
4 years, 6 months ago (2016-06-23 23:10:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095623003/40001
4 years, 6 months ago (2016-06-23 23:32:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/244554)
4 years, 6 months ago (2016-06-24 02:08:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095623003/40001
4 years, 6 months ago (2016-06-24 02:09:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/206467)
4 years, 6 months ago (2016-06-24 02:16:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095623003/60001
4 years, 6 months ago (2016-06-24 04:26:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/244710)
4 years, 6 months ago (2016-06-24 05:15:26 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095623003/60001
4 years, 6 months ago (2016-06-24 05:42:53 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/234889)
4 years, 6 months ago (2016-06-24 06:29:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095623003/60001
4 years, 6 months ago (2016-06-24 15:11:28 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/244924)
4 years, 6 months ago (2016-06-24 17:43:13 UTC) #26
mcasas
On 2016/06/24 17:43:13, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-24 18:02:03 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095623003/60001
4 years, 6 months ago (2016-06-24 18:02:48 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-24 19:24:44 UTC) #31
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 19:26:49 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d2f53ea376660b150b8bdc7d1341a43db557711e
Cr-Commit-Position: refs/heads/master@{#401927}

Powered by Google App Engine
This is Rietveld 408576698