Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 2095593003: Revert of Move memory-infra check from background tracing and whitelist memory dump args (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@enabled_modes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move memory-infra check from background tracing and whitelist memory dump args (patchset #1 id:20001 of https://codereview.chromium.org/2092463002/ ) Reason for revert: Speculative revert. Looks like this could have broken mac and linux sizes: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21314 Original issue's description: > Move memory-infra check from background tracing and whitelist memory dump args > > BUG=613198 > > Committed: https://crrev.com/7d2fd66cc632f2fcf5fb821936cdac319f7f8233 > Cr-Commit-Position: refs/heads/master@{#401652} TBR=primiano@chromium.org,oysteine@chromium.org,ssid@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613198 Committed: https://crrev.com/a8b0d1386ef9ae3f3f45316c0e5bd4d39a8e5a22 Cr-Commit-Position: refs/heads/master@{#401725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/trace_event_args_whitelist.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Created Revert of Move memory-infra check from background tracing and whitelist memory dump args
4 years, 6 months ago (2016-06-23 21:26:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2095593003/1
4 years, 6 months ago (2016-06-23 21:27:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 21:28:34 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8b0d1386ef9ae3f3f45316c0e5bd4d39a8e5a22 Cr-Commit-Position: refs/heads/master@{#401725}
4 years, 6 months ago (2016-06-23 21:29:58 UTC) #6
ssid
4 years, 6 months ago (2016-06-23 21:35:09 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2090953004/ by ssid@chromium.org.

The reason for reverting is: Changing the category to use const char* string
"memory-infra" instead of the static memory kTraceCategory, to avoid static
initialization..

Powered by Google App Engine
This is Rietveld 408576698