Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2095583002: Rolling DEPS for third_party/ced (Closed)

Created:
4 years, 6 months ago by Jinsuk Kim
Modified:
4 years, 5 months ago
Reviewers:
tkent, brettw
CC:
tkent, aelias_OOO_until_Jul13, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rolling DEPS for third_party/ced This updates add a new utility method used to do string-to-enum conversion for text encoding name. BUG=597488 TEST=gclient sync, make Committed: https://crrev.com/dc3932694326d603b9b40dec5f0f6fcf463eaa65 Cr-Commit-Position: refs/heads/master@{#402088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Jinsuk Kim
4 years, 6 months ago (2016-06-23 09:48:10 UTC) #2
Jinsuk Kim
ping?
4 years, 5 months ago (2016-06-25 05:11:29 UTC) #3
tkent
lgtm
4 years, 5 months ago (2016-06-26 21:07:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095583002/1
4 years, 5 months ago (2016-06-26 21:08:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-26 22:07:02 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dc3932694326d603b9b40dec5f0f6fcf463eaa65 Cr-Commit-Position: refs/heads/master@{#402088}
4 years, 5 months ago (2016-06-26 22:08:49 UTC) #10
Jinsuk Kim
4 years, 5 months ago (2016-06-27 17:10:32 UTC) #11
Message was sent while issue was closed.
On 2016/06/26 22:08:49, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/dc3932694326d603b9b40dec5f0f6fcf463eaa65
> Cr-Commit-Position: refs/heads/master@{#402088}

Thanks tkent for help!

Powered by Google App Engine
This is Rietveld 408576698