Make callers of FromUTC(Local)Exploded in components/ use new time API.

components/password_manager/core/browser/password_store.cc

Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index 9842dc2b545492c5b6757e01b8018133f34a776f..7b8d0625a2e18dfe618a9b213aab4330948871bf 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -177,7 +177,14 @@ void PasswordStore::GetLogins(const PasswordForm& form,
        form.signon_realm == "https://www.google.com/")) {
     static const base::Time::Exploded exploded_cutoff =
         { 2012, 1, 0, 1, 0, 0, 0, 0 };  // 00:00 Jan 1 2012
-    ignore_logins_cutoff = base::Time::FromUTCExploded(exploded_cutoff);
+    base::Time out_time;
+    if (base::Time::FromUTCExploded(exploded_cutoff, &out_time)) {

[vabr (Chromium), 2016/06/28 14:34:12]

This is called for a constant |exploded_cutoff|. Is that not a guarantee that
this won't fail? If you agree, I sugest the following:

bool time_conversion_succeeded = base::Time::FromUTCExploded(exploded_cutoff,
&ignore_logins_cutoff);
DCHECK(time_conversion_succeeded);

Note 2 things:
(1) The conversion itself must not be inside the DCHECK, or it won't happen in
Release builds.
(2) No attempt is made to handle the failing DCHECK-ed condition in Release
builds, because the style guide forbids it
(http://dev.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-).

[maksims (do not use this acc), 2016/06/29 05:48:59]

Oh, correct. It will never ever fail. I haven't checked that. I have a bunch of
callers to be modified and I didn't get that deep into the code to check what
time was used.

+      ignore_logins_cutoff = out_time;
+    } else {
+      // TODO(maksims) implement error handling.
+      // |out_time| is Time(0) here.
+      NOTIMPLEMENTED();
+    }
   }
   std::unique_ptr<GetLoginsRequest> request(new GetLoginsRequest(consumer));
   request->set_ignore_logins_cutoff(ignore_logins_cutoff);