Make callers of FromUTC(Local)Exploded in components/ use new time API.

components/autofill/content/browser/risk/fingerprint.cc

Index: components/autofill/content/browser/risk/fingerprint.cc
diff --git a/components/autofill/content/browser/risk/fingerprint.cc b/components/autofill/content/browser/risk/fingerprint.cc
index 08ed54eb772b256dc17b4fd375f9b93030c4a24b..02f76e23bf192bdf666e37d0481e1c624523012b 100644
--- a/components/autofill/content/browser/risk/fingerprint.cc
+++ b/components/autofill/content/browser/risk/fingerprint.cc
@@ -65,8 +65,14 @@ base::TimeDelta GetTimezoneOffset() {
 
   base::Time::Exploded local;
   utc.LocalExplode(&local);
-
-  return base::Time::FromUTCExploded(local) - utc;
+  base::Time out_time;
+  // |out_time| is set to Time(0) on failure.
+  if (!base::Time::FromUTCExploded(local, &out_time)) {

[vabr (Chromium), 2016/06/28 14:34:12]

Given that the exploded value comes from the result of base::Time::Now(), how
could FromUTCExploded fail on it? It seems to me that a DCHECK is in order here:

bool conversion_success = base::Time::FromUTCExploded(local, &out_time);
DCHECK(conversion_success);

Please note that for reasons explained in my other comment, the conversion must
not be placed inside the DCHECK, and the DCHECK failure must not be handled.

[maksims (do not use this acc), 2016/06/29 05:48:59]

Correct, it will never fail in this case.

+    // TODO(maksims): implement error handling.
+    // |out_time| is Time(0) here.
+    NOTIMPLEMENTED();
+  }
+  return out_time - utc;
 }
 
 // Returns the concatenation of the operating system name and version, e.g.