components/ntp_snippets/ntp_snippets_service.cc - Issue 2095553002: Make callers of FromUTC(Local)Exploded in components/ use new time API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 2095553002: Make callers of FromUTC(Local)Exploded in components/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fukino's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/drive/service/fake_drive_service_unittest.cc ('k') | components/ntp_snippets/ntp_snippets_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service.cc

diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc

index 08f4203ee247b5afbf6de0e80bbce4d2d0a56ed2..4b18a58f6469486d06d8de08277f7ab909edd59d 100644

--- a/components/ntp_snippets/ntp_snippets_service.cc

+++ b/components/ntp_snippets/ntp_snippets_service.cc

@@ -139,7 +139,11 @@ base::Time GetRescheduleTime(const base::Time& now) {

exploded.minute = 0;

exploded.second = 0;

exploded.millisecond = 0;

- base::Time reschedule = base::Time::FromLocalExploded(exploded);

+ base::Time reschedule;

+ if (!base::Time::FromLocalExploded(exploded, &reschedule)) {

+ return GetRescheduleTime(now + base::TimeDelta::FromDays(1));

+ }

if (next_day)

reschedule += base::TimeDelta::FromDays(1);