Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: components/autofill/content/browser/risk/fingerprint.cc

Issue 2095553002: Make callers of FromUTC(Local)Exploded in components/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fukino's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_usage_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/browser/risk/fingerprint.cc
diff --git a/components/autofill/content/browser/risk/fingerprint.cc b/components/autofill/content/browser/risk/fingerprint.cc
index 08ed54eb772b256dc17b4fd375f9b93030c4a24b..67d4847ff01ce8326c7cbe1d36fad40343ae6795 100644
--- a/components/autofill/content/browser/risk/fingerprint.cc
+++ b/components/autofill/content/browser/risk/fingerprint.cc
@@ -66,7 +66,11 @@ base::TimeDelta GetTimezoneOffset() {
base::Time::Exploded local;
utc.LocalExplode(&local);
- return base::Time::FromUTCExploded(local) - utc;
+ base::Time out_time;
+ bool conversion_success = base::Time::FromUTCExploded(local, &out_time);
+ DCHECK(conversion_success);
+
+ return out_time - utc;
}
// Returns the concatenation of the operating system name and version, e.g.
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_usage_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698