net/ssl/channel_id_store.cc - Issue 2095523002: Make //crypto factories return std::unique_ptr<>s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/channel_id_store.cc

Issue 2095523002: Make //crypto factories return std::unique_ptr<>s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ssl/channel_id_store.cc

diff --git a/net/ssl/channel_id_store.cc b/net/ssl/channel_id_store.cc

index 1d0078b968f38f7977423d8186d824618c1675b1..9545585e87c3dc20fca31e810d02b2a044bbebe2 100644

--- a/net/ssl/channel_id_store.cc

+++ b/net/ssl/channel_id_store.cc

@@ -33,7 +33,7 @@ ChannelIDStore::ChannelID& ChannelIDStore::ChannelID::operator=(

server_identifier_ = other.server_identifier_;

creation_time_ = other.creation_time_;

if (other.key_)

- key_.reset(other.key_->Copy());

+ key_ = other.key_->Copy();

return *this;

}